r48890 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48889‎ | r48890 | r48891 >
Date:17:40, 26 March 2009
Author:demon
Status:ok
Tags:
Comment:
Followup to r48889 (removing svn-version/svn-date from extensions): remove support for svn-version in Special:Version. On a sidenote, svn-date doesn't seem used at all.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialVersion.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialVersion.php
@@ -162,18 +162,7 @@
163163 if ( isset( $extension['version'] ) ) {
164164 $version = $extension['version'];
165165 }
166 - if ( isset( $extension['svn-revision'] ) &&
167 - preg_match( '/\$(?:Rev|LastChangedRevision|Revision): *(\d+)/',
168 - $extension['svn-revision'], $m ) ) {
169 - $subVersion = 'r' . $m[1];
170 - }
171166
172 - if( $version && $subVersion ) {
173 - $version = $version . ' [' . $subVersion . ']';
174 - } elseif ( !$version && $subVersion ) {
175 - $version = $subVersion;
176 - }
177 -
178167 $out .= $this->formatCredits(
179168 isset ( $extension['name'] ) ? $extension['name'] : '',
180169 $version,
Index: trunk/phase3/RELEASE-NOTES
@@ -116,7 +116,6 @@
117117 * Special:ListUsers: Sort list of usergroups by alphabet
118118 * (bug 16762) Special:Movepage now shows a list of subpages when possible
119119 * (bug 17585) Hide legend on Special:Specialpages from non-privileged users
120 -
121120 * Added $wgUseTagFilter to control enabling of filter-by-change-tag
122121 * (bug 17291) MediaWiki:Nocontribs now has an optional $1 parameter for the
123122 username
@@ -292,6 +291,7 @@
293292 * (bug 16343) Non-existing, but in use, category pages can be "go" match hits
294293 * (bug 18031) Make namespace selector on Special:Export remember the previous
295294 selection
 295+* The svn-version version numbers on Special:Version have been removed
296296
297297 == API changes in 1.15 ==
298298 * (bug 16858) Revamped list=deletedrevs to make listing deleted contributions

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r48889Big commit. Removing svn-version and svn-date from extensions. Per the list, ...demon17:39, 26 March 2009

Status & tagging log