r48888 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48887‎ | r48888 | r48889 >
Date:17:02, 26 March 2009
Author:aaron
Status:reverted
Tags:
Comment:
Fix for r48839: log deletion uses a different action
Modified paths:
  • /trunk/phase3/includes/specials/SpecialRevisiondelete.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRevisiondelete.php
@@ -126,6 +126,7 @@
127127
128128 private function getLogQueryCond() {
129129 $ids = $safeIds = array();
 130+ $action = 'revision';
130131 switch( $this->deleteKey ) {
131132 case 'oldid':
132133 $ids = $this->oldids;
@@ -141,10 +142,11 @@
142143 break;
143144 case 'logid':
144145 $ids = $this->logids;
 146+ $action = 'event';
145147 break;
146148 }
147149 // Revision delete logs
148 - $conds = array( 'log_action' => 'revision' );
 150+ $conds = array( 'log_action' => $action );
149151 // Just get the whole log if there are a lot if items
150152 if( count($ids) > 20 ) return $conds;
151153 // Digit chars only

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r48839(bug 15814) Filter log chunk at Special:RevisionDelete to selected itemsaaron18:25, 25 March 2009

Status & tagging log