r48276 MediaWiki - Code Review archive

Why remove per-page editnotices at all? But if you are going to remove them, why only remove them from namespaces without subpages enabled? And why not fix the comment on line 427 while you're at it?

because. this feature introduced bad practices, message namespace and message cache should never be used for per-page dynamism of any sort. if you need, you can put editnotices in some subpage of project namespace, etc, and include them via template.

The editnotice is shown on the EditPage above the main edit window.

An example of this (which will disappear when this goes live) is the box above

ANI's edit page

Yes, this material could be moved out of the Mediawiki space, but I don't believe Mediawiki presently provides any natural alternative way to get a per page message into the space above the edit window. Am I wrong about that?

mediawiki doesn't provide lots of things, that shouldn't be reason of allowing bad practices in.

oh, and this change is live anyway :)

I figured out my confusion. ANI's board is still live because your changes never disabled per page editnotices in namespaces that have subpages. The second jump in the diff above is hiding:

        if ( MWNamespace::hasSubpages( $this->mTitle->getNamespace() ) ) {
            $parts = explode( '/', $this->mTitle->getDBkey() );
            $editnotice_base = $editnotice_ns;
            while ( count( $parts ) > 0 ) {
                $editnotice_base .= '-'.array_shift( $parts );
                if ( !wfEmptyMsg( $editnotice_base, wfMsgForContent( $editnotice_base ) ) ) {
                    $wgOut->addWikiText( wfMsgForContent( $editnotice_base )  );
                }
            }
        }

Which generates per-page notices for namespaces with subpages. Was it intentional to leave that functionality in? Given your motivation, it seems more likely to be an accident.

The related bug regarding this is 15102.

Why not code some namespace for it?

A specific namespace just for edit notices? That's an even worse idea.

What would make sense - ability to have protected subpages in certain namespace. Then one could do Project:Editnotices/Blah/Blah without fear of having vandals come and do bad things.

The Title Blacklist extension already provides that functionality.

Here you go ;-)

How do i get this to work?

Do you mean to ask how to get per-page editnotices to work? I guess putting {{Project:Editnotices/{{FULLPAGENAME}}}} (wrapped in an #ifexist for prettiness of course) in MediaWiki:editnotice would do.

Actually there doesn't appear to be a generic Mediawiki:editnotice. Rather there are a series of namespace notices, e.g. Mediawiki:editnotice-0, where the number is the namespace number. There are also other related messages, like the editing protected page message, but they aren't globally relevant.

Enwiki is headed in the direction you describe but currently going towards Template:Editnotices as the root rather than Project.

r97686 restores this with a tweak to normalize '/' chars into '-' -- should that stay or be reverted again?

ignore me