r48277 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48276‎ | r48277 | r48278 >
Date:19:15, 10 March 2009
Author:aaron
Status:resolved (Comments)
Tags:
Comment:
minor tweak: revisiondelete id url param is an array
Modified paths:
  • /trunk/phase3/includes/ImagePage.php (modified) (history)
  • /trunk/phase3/includes/LogEventsList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ImagePage.php
@@ -789,7 +789,7 @@
790790 $q = array();
791791 $q[] = 'action=delete';
792792 if( !$iscur )
793 - $q[] = 'oldimage=' . urlencode( $img );
 793+ $q[] = 'oldimage[]=' . urlencode( $img );
794794 $row .= $this->skin->makeKnownLinkObj(
795795 $this->title,
796796 wfMsgHtml( $iscur ? 'filehist-deleteall' : 'filehist-deleteone' ),
Index: trunk/phase3/includes/LogEventsList.php
@@ -360,7 +360,7 @@
361361 } else {
362362 $target = SpecialPage::getTitleFor( 'Log', $row->log_type );
363363 $query = array( 'target' => $target->getPrefixedDBkey(),
364 - 'logid' => $row->log_id
 364+ 'logid[]' => $row->log_id
365365 );
366366 $del = $this->skin->revDeleteLink( $query, self::isDeleted( $row, LogPage::DELETED_RESTRICTED ) );
367367 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r50469Fixed bug 18171 (broken image deletion) by partial revert of r48277.tstarling06:22, 11 May 2009

Comments

#Comment by Aaron Schulz (talk | contribs)   06:20, 22 April 2009

The oldimage[] change here is wrong (it is for the wrong type of delete). Fixed in r48837.

Status & tagging log