r97686 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97685‎ | r97686 | r97687 >
Date:00:19, 21 September 2011
Author:bawolff
Status:ok (Comments)
Tags:
Comment:
Make per page edit notices work in namespaces without subpages enabled.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -467,6 +467,13 @@
468468 $wgOut->addWikiText( $editnotice_base_msg->plain() );
469469 }
470470 }
 471+ } else {
 472+ # Even if there are no subpages in namespace, we still don't want / in MW ns.
 473+ $editnoticeText = $editnotice_ns . '-' . str_replace( '/', '-', $this->mTitle->getDBkey() );
 474+ $editnoticeMsg = wfMessage( $editnoticeText )->inContentLanguage();
 475+ if ( $editnoticeMsg->exists() ) {
 476+ $wgOut->addWikiText( $editnoticeMsg->plain() );
 477+ }
471478 }
472479
473480 # Attempt submission here. This will check for edit conflicts,
Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -94,6 +94,7 @@
9595 * (bug 30907) Special:Unusedcategories should sort ascendingly.
9696 * (bug 18424) Special:Prefixindex and Special:Allpages paging links are
9797 really small, and somewhat inconsistent with each other.
 98+* Per page edit-notices now work in namespaces without subpages enabled.
9899
99100 === API changes in 1.19 ===
100101 * (bug 19838) siprop=interwikimap can now use the interwiki cache.

Sign-offs

UserFlagDate
Krinkleinspected00:24, 21 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r48276remove per-page editnotice functionality, message files and message cache are...midom18:57, 10 March 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   22:23, 21 September 2011

This was removed in r48276 by Domas, "remove per-page editnotice functionality, message files and message cache are supposed to be global data."

#Comment by Bawolff (talk | contribs)   12:50, 22 September 2011

Whoops didn't realize it's been previously implemented and reverted. Personally I think it is really weird that this is ok for non-subpaged namespaces, but not for subpage namespaces.

Is this ok, or should it be reverted?

#Comment by Happy-melon (talk | contribs)   01:18, 15 January 2012

Only because the removal was incomplete; the intention was to remove the feature entirely. IMO Domas' reasons for wanting to not have this still apply. Enwiki has demonstrated a perfectly acceptable alternative using a loader template (substantially more complicated than the minimum required to get the job done, but that's enwiki for you :D) to conditionally include a subpage of a hierarchy protected by TitleBlacklist.

#Comment by Brion VIBBER (talk | contribs)   22:25, 21 September 2011

Bug 15102 requests this being added/restored...

#Comment by He7d3r (talk | contribs)   11:23, 30 December 2012

Status & tagging log