r47730 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47729‎ | r47730 | r47731 >
Date:23:05, 23 February 2009
Author:aaron
Status:resolved (Comments)
Tags:
Comment:
Fix timestamp bug from r47709
Modified paths:
  • /trunk/phase3/includes/specials/SpecialRevisiondelete.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRevisiondelete.php
@@ -227,19 +227,18 @@
228228 'ar_timestamp' => $where ),
229229 __METHOD__ );
230230 while( $row = $dbr->fetchObject( $result ) ) {
231 - $timestamp = wfTimestamp( TS_MW, $timestamp );
232231 $revObjs[$timestamp] = new Revision( array(
233 - 'page' => $this->page->getArticleId(),
234 - 'id' => $row->ar_rev_id,
235 - 'text' => $row->ar_text_id,
236 - 'comment' => $row->ar_comment,
237 - 'user' => $row->ar_user,
238 - 'user_text' => $row->ar_user_text,
239 - 'timestamp' => $timestamp,
240 - 'minor_edit' => $row->ar_minor_edit,
241 - 'text_id' => $row->ar_text_id,
242 - 'deleted' => $row->ar_deleted,
243 - 'len' => $row->ar_len) );
 232+ 'page' => $this->page->getArticleId(),
 233+ 'id' => $row->ar_rev_id,
 234+ 'text' => $row->ar_text_id,
 235+ 'comment' => $row->ar_comment,
 236+ 'user' => $row->ar_user,
 237+ 'user_text' => $row->ar_user_text,
 238+ 'timestamp' => wfTimestamp( TS_MW, $timestamp ),
 239+ 'minor_edit' => $row->ar_minor_edit,
 240+ 'text_id' => $row->ar_text_id,
 241+ 'deleted' => $row->ar_deleted,
 242+ 'len' => $row->ar_len) );
244243 }
245244 foreach( $this->archrevs as $timestamp ) {
246245 if( !isset($revObjs[$timestamp]) ) {
@@ -890,7 +889,6 @@
891890 'ar_timestamp' => $where ),
892891 __METHOD__ );
893892 while( $row = $this->dbw->fetchObject( $result ) ) {
894 - $timestamp = wfTimestamp( TS_MW, $row->ar_timestamp );
895893 $revObjs[$timestamp] = new Revision( array(
896894 'page' => $title->getArticleId(),
897895 'id' => $row->ar_rev_id,
@@ -898,7 +896,7 @@
899897 'comment' => $row->ar_comment,
900898 'user' => $row->ar_user,
901899 'user_text' => $row->ar_user_text,
902 - 'timestamp' => $timestamp,
 900+ 'timestamp' => wfTimestamp( TS_MW, $row->ar_timestamp ),
903901 'minor_edit' => $row->ar_minor_edit,
904902 'text_id' => $row->ar_text_id,
905903 'deleted' => $row->ar_deleted,

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r47709Tweaks for Special:RevisonDelete:...ialex16:48, 23 February 2009

Comments

#Comment by Aaron Schulz (talk | contribs)   16:56, 24 February 2009

Actually done in r47742

Status & tagging log