r47731 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47730‎ | r47731 | r47732 >
Date:23:18, 23 February 2009
Author:aaron
Status:ok
Tags:
Comment:
Fix double-escaping from r47466 (feed calls getUrl() which calls xmlEncode() which escapes it)
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -288,7 +288,8 @@
289289 $feed = new $wgFeedClasses[$type](
290290 $this->feedTitle(),
291291 wfMsgExt( 'tagline', 'parsemag' ),
292 - $this->getTitle()->getFullUrl() . "/" . htmlspecialchars( $this->opts['target'] ) );
 292+ $this->getTitle()->getFullUrl() . "/" . urlencode($this->opts['target'])
 293+ );
293294
294295 // Already valid title
295296 $nt = Title::makeTitleSafe( NS_USER, $this->opts['target'] );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r47466(bug 17556) <link> parameters in Special:Contributions feeds (RSS and Atom) n...demon20:00, 18 February 2009

Status & tagging log