r47742 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47741‎ | r47742 | r47743 >
Date:11:52, 24 February 2009
Author:ialex
Status:ok
Tags:
Comment:
Correct fix for r47709: the second parameter to wfTimestamp() was supposed to be $row->ar_timestamp :)
Modified paths:
  • /trunk/phase3/includes/specials/SpecialRevisiondelete.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRevisiondelete.php
@@ -227,6 +227,7 @@
228228 'ar_timestamp' => $where ),
229229 __METHOD__ );
230230 while( $row = $dbr->fetchObject( $result ) ) {
 231+ $timestamp = wfTimestamp( TS_MW, $row->ar_timestamp );
231232 $revObjs[$timestamp] = new Revision( array(
232233 'page' => $this->page->getArticleId(),
233234 'id' => $row->ar_rev_id,
@@ -234,7 +235,7 @@
235236 'comment' => $row->ar_comment,
236237 'user' => $row->ar_user,
237238 'user_text' => $row->ar_user_text,
238 - 'timestamp' => wfTimestamp( TS_MW, $timestamp ),
 239+ 'timestamp' => $timestamp,
239240 'minor_edit' => $row->ar_minor_edit,
240241 'text_id' => $row->ar_text_id,
241242 'deleted' => $row->ar_deleted,
@@ -889,6 +890,7 @@
890891 'ar_timestamp' => $where ),
891892 __METHOD__ );
892893 while( $row = $this->dbw->fetchObject( $result ) ) {
 894+ $timestamp = wfTimestamp( TS_MW, $row->ar_timestamp );
893895 $revObjs[$timestamp] = new Revision( array(
894896 'page' => $title->getArticleId(),
895897 'id' => $row->ar_rev_id,
@@ -896,7 +898,7 @@
897899 'comment' => $row->ar_comment,
898900 'user' => $row->ar_user,
899901 'user_text' => $row->ar_user_text,
900 - 'timestamp' => wfTimestamp( TS_MW, $row->ar_timestamp ),
 902+ 'timestamp' => $timestamp,
901903 'minor_edit' => $row->ar_minor_edit,
902904 'text_id' => $row->ar_text_id,
903905 'deleted' => $row->ar_deleted,

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r47709Tweaks for Special:RevisonDelete:...ialex16:48, 23 February 2009

Status & tagging log