r47619 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47618‎ | r47619 | r47620 >
Date:16:04, 21 February 2009
Author:raymond
Status:reverted (Comments)
Tags:
Comment:
Add an ID if 'missingsummary' is triggered to allow styling of the summary line
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -1343,10 +1343,13 @@
13441344 if ( $this->section == 'new' ) {
13451345 $commentsubject = '';
13461346 if ( !$wgRequest->getBool( 'nosummary' ) ) {
 1347+ # Add an ID if 'missingsummary' is triggered to allow styling of the summary line
 1348+ $summaryMissedID = $this->missingSummary ? ' mw-summarymissed' : '';
 1349+
13471350 $commentsubject =
13481351 Xml::tags( 'label', array( 'for' => 'wpSummary' ), $subject );
13491352 $commentsubject =
1350 - Xml::tags( 'span', array( 'id' => 'wpSummaryLabel' ), $commentsubject );
 1353+ Xml::tags( 'span', array( 'id' => "wpSummaryLabel$summaryMissedID" ), $commentsubject );
13511354 $commentsubject .= ' ';
13521355 $commentsubject .= Xml::input( 'wpSummary',
13531356 60,
@@ -1365,10 +1368,12 @@
13661369 } else {
13671370 $commentsubject = '';
13681371
 1372+ # Add an ID if 'missingsummary' is triggered to allow styling of the summary line
 1373+ $summaryMissedID = $this->missingSummary ? ' mw-summarymissed' : '';
 1374+
13691375 $editsummary = Xml::tags( 'label', array( 'for' => 'wpSummary' ), $summary );
1370 - $editsummary =
1371 - Xml::tags( 'span', array( 'id' => 'wpSummaryLabel' ), $editsummary ) . ' ';
1372 -
 1376+ $editsummary = Xml::tags( 'span', array( 'id' => "wpSummaryLabel$summaryMissedID" ), $editsummary ) . ' ';
 1377+
13731378 $editsummary .= Xml::input( 'wpSummary',
13741379 60,
13751380 $summarytext,
@@ -1377,11 +1382,11 @@
13781383 'maxlength' => '200',
13791384 'tabindex' => '1'
13801385 ) );
1381 -
 1386+
13821387 // No idea where this is closed.
13831388 $editsummary = Xml::openElement( 'div', array( 'class' => 'editOptions' ) )
13841389 . $editsummary . '<br/>';
1385 -
 1390+
13861391 $summarypreview = '';
13871392 if ( $summarytext && $this->preview ) {
13881393 $summarypreview =
Index: trunk/phase3/RELEASE-NOTES
@@ -115,7 +115,8 @@
116116 * (bug 17585) Hide legend on Special:Specialpages from non-privileged users
117117 * (bug 15876) Users with 'reset-passwords' right can change the passwords of
118118 other users.
119 -
 119+* Add an ID if 'missingsummary' is triggered to allow styling of the summary
 120+ line
120121 === Bug fixes in 1.15 ===
121122 * (bug 16968) Special:Upload no longer throws useless warnings.
122123 * (bug 17000) Special:RevisionDelete now checks if the database is locked

Follow-up revisions

RevisionCommit summaryAuthorDate
r48798Revert r47619 "Add an ID if 'missingsummary' is triggered to allow styling of...brion09:24, 25 March 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   09:24, 25 March 2009

Invalid HTML -- an element may have only one id value, they're not like classes.

Reverted in r48798

Status & tagging log