r48798 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48797‎ | r48798 | r48799 >
Date:09:24, 25 March 2009
Author:brion
Status:ok
Tags:
Comment:
Revert r47619 "Add an ID if 'missingsummary' is triggered to allow styling of the summary line"
Invalid HTML -- an element may have only one id value, they're not like classes.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -1363,13 +1363,10 @@
13641364 if ( $this->section == 'new' ) {
13651365 $commentsubject = '';
13661366 if ( !$wgRequest->getBool( 'nosummary' ) ) {
1367 - # Add an ID if 'missingsummary' is triggered to allow styling of the summary line
1368 - $summaryMissedID = $this->missingSummary ? ' mw-summarymissed' : '';
1369 -
13701367 $commentsubject =
13711368 Xml::tags( 'label', array( 'for' => 'wpSummary' ), $subject );
13721369 $commentsubject =
1373 - Xml::tags( 'span', array( 'id' => "wpSummaryLabel$summaryMissedID" ), $commentsubject );
 1370+ Xml::tags( 'span', array( 'id' => 'wpSummaryLabel' ), $commentsubject );
13741371 $commentsubject .= ' ';
13751372 $commentsubject .= Xml::input( 'wpSummary',
13761373 60,
@@ -1388,12 +1385,10 @@
13891386 } else {
13901387 $commentsubject = '';
13911388
1392 - # Add an ID if 'missingsummary' is triggered to allow styling of the summary line
1393 - $summaryMissedID = $this->missingSummary ? ' mw-summarymissed' : '';
1394 -
13951389 $editsummary = Xml::tags( 'label', array( 'for' => 'wpSummary' ), $summary );
1396 - $editsummary = Xml::tags( 'span', array( 'id' => "wpSummaryLabel$summaryMissedID" ), $editsummary ) . ' ';
1397 -
 1390+ $editsummary =
 1391+ Xml::tags( 'span', array( 'id' => 'wpSummaryLabel' ), $editsummary ) . ' ';
 1392+
13981393 $editsummary .= Xml::input( 'wpSummary',
13991394 60,
14001395 $summarytext,
@@ -1402,11 +1397,11 @@
14031398 'maxlength' => '200',
14041399 'tabindex' => '1'
14051400 ) );
1406 -
 1401+
14071402 // No idea where this is closed.
14081403 $editsummary = Xml::openElement( 'div', array( 'class' => 'editOptions' ) )
14091404 . $editsummary . '<br/>';
1410 -
 1405+
14111406 $summarypreview = '';
14121407 if ( $summarytext && $this->preview ) {
14131408 $summarypreview =
Index: trunk/phase3/RELEASE-NOTES
@@ -116,8 +116,7 @@
117117 * Special:ListUsers: Sort list of usergroups by alphabet
118118 * (bug 16762) Special:Movepage now shows a list of subpages when possible
119119 * (bug 17585) Hide legend on Special:Specialpages from non-privileged users
120 -* Add an ID if 'missingsummary' is triggered to allow styling of the summary
121 - line
 120+
122121 * Added $wgUseTagFilter to control enabling of filter-by-change-tag
123122 * (bug 17291) MediaWiki:Nocontribs now has an optional $1 parameter for the
124123 username

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r47619Add an ID if 'missingsummary' is triggered to allow styling of the summary lineraymond16:04, 21 February 2009

Status & tagging log