r47618 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47617‎ | r47618 | r47619 >
Date:15:27, 21 February 2009
Author:ialex
Status:ok
Tags:
Comment:
Fixed Special:Wantedtemplates' SQL query to work with PostgreSQL, was throwing the following error:
ERROR: column "templatelinks.tl_namespace" must appear in the GROUP BY clause or be used in an aggregate function
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialWantedtemplates.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialWantedtemplates.php
@@ -42,7 +42,7 @@
4343 FROM $templatelinks LEFT JOIN
4444 $page ON tl_title = page_title AND tl_namespace = page_namespace
4545 WHERE page_title IS NULL AND tl_namespace = ". NS_TEMPLATE ."
46 - GROUP BY tl_title
 46+ GROUP BY tl_namespace, tl_title
4747 ";
4848 }
4949
Index: trunk/phase3/RELEASE-NOTES
@@ -209,7 +209,9 @@
210210 * (bug 17538) Use shorter URLs in <link> elements
211211 * (bug 13778) Hidden input added to the search form so that using the Enter key
212212 on IE will do a fulltext search like clicking the button does
213 -* (bug 1061) CSS-added icons next to links display through the text and makes it unreadable in RTL
 213+* (bug 1061) CSS-added icons next to links display through the text and makes
 214+ it unreadable in RTL
 215+* Special:Wantedtemplates now works on PostgreSQL
214216
215217 == API changes in 1.15 ==
216218 * (bug 16858) Revamped list=deletedrevs to make listing deleted contributions

Status & tagging log