r46372 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46371‎ | r46372 | r46373 >
Date:19:53, 27 January 2009
Author:demon
Status:ok (Comments)
Tags:
Comment:
(bug 17180) Go ahead and disable $wgShowIPinHeader if we're using $wgUseFileCache.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Setup.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Setup.php
@@ -197,6 +197,11 @@
198198 # To determine the user language, use $wgLang->getCode()
199199 $wgContLanguageCode = $wgLanguageCode;
200200
 201+# If file caching is enabled, disable $wgShowIPInHeader
 202+if ( $wgUseFileCache ) {
 203+ $wgShowIPinHeader = false;
 204+}
 205+
201206 wfProfileOut( $fname.'-misc1' );
202207 wfProfileIn( $fname.'-memcached' );
203208
Index: trunk/phase3/RELEASE-NOTES
@@ -67,6 +67,8 @@
6868 * (bug 3301) Optionally sort user list according to account creation time
6969 * Remote description pages for foreign file repos are now fetched in the
7070 content language.
 71+* (bug 17180) If $wgUseFileCache is enabled, $wgShowIPinHeader is automatically
 72+ set to false.
7173
7274 === Bug fixes in 1.15 ===
7375 * (bug 16968) Special:Upload no longer throws useless warnings.

Follow-up revisions

RevisionCommit summaryAuthorDate
r46374(bug 17180) Disable $wgShowIPinHeader if static caching is enabledaaron19:58, 27 January 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   20:01, 27 January 2009

r46374 does this also for $wgUseSquid mode

Status & tagging log