r46374 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46373‎ | r46374 | r46375 >
Date:19:58, 27 January 2009
Author:aaron
Status:ok
Tags:
Comment:
(bug 17180) Disable $wgShowIPinHeader if static caching is enabled
Modified paths:
  • /trunk/phase3/includes/Setup.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Setup.php
@@ -197,10 +197,9 @@
198198 # To determine the user language, use $wgLang->getCode()
199199 $wgContLanguageCode = $wgLanguageCode;
200200
201 -# If file caching is enabled, disable $wgShowIPInHeader
202 -if ( $wgUseFileCache ) {
203 - $wgShowIPinHeader = false;
204 -}
 201+# Easy to forget to falsify $wgShowIPinHeader for static caches.
 202+# If file cache or squid cache is on, just disable this (DWIMD).
 203+if( $wgUseFileCache || $wgUseSquid ) $wgShowIPinHeader = false;
205204
206205 wfProfileOut( $fname.'-misc1' );
207206 wfProfileIn( $fname.'-memcached' );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r46372(bug 17180) Go ahead and disable $wgShowIPinHeader if we're using $wgUseFileC...demon19:53, 27 January 2009

Status & tagging log