r45687 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r45686‎ | r45687 | r45688 >
Date:22:52, 12 January 2009
Author:charlie
Status:resolved (Comments)
Tags:
Comment:
Fix a problem with a protected class method that brought up an error, and also
fixed a typo in the release notes.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/RecentChange.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/RecentChange.php
——@@ -593,7 +593,7 @@
594594 return $trail;
595595 }
596596
597 - protected function getIRCLine() {
 597+ public function getIRCLine() {
598598 global $wgUseRCPatrol, $wgUseNPPatrol, $wgRC2UDPInterwikiPrefix, $wgLocalInterwiki;
599599
600600 // FIXME: Would be good to replace these 2 extract() calls with something more explicit
Index: trunk/phase3/RELEASE-NOTES
——@@ -29,7 +29,7 @@
3030 * Added "Advanced search" link to the search form
3131 * Special:Upload can now have a custom upload message instead of uploadtext by
3232 passing "uploadmsg" parameter in the url
33 -* (bug 9947) Add PROTECTIONLEVEL parser funtion to return the protection level
 33+* (bug 9947) Add PROTECTIONLEVEL parser function to return the protection level
3434 for the current page for a given action
3535 * Added "__\" magic word to eat up all whitespace and newlines to the next
3636 non-whitespace character, to facilitate writing readable template code where

Comments

#Comment by Cmelbye (talk | contribs)   01:20, 13 January 2009

As I told Skizzerz on IRC, the place where RecentChange::getIRCLine() was being called was on LogPage.php around line 98.

#Comment by Brion VIBBER (talk | contribs)   20:19, 14 January 2009

Hmm, I think the problem here was that the calling code was poorly factored -- it should have been calling a public function which called this one.

#Comment by Aaron Schulz (talk | contribs)   13:39, 16 January 2009

Refactored in r45762

Status & tagging log