r45762 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45761‎ | r45762 | r45763 >
Date:01:42, 15 January 2009
Author:aaron
Status:ok
Tags:
Comment:
Use new notifyRC2UDP() function in LogPage to avoid duplicated code
Modified paths:
  • /trunk/phase3/includes/LogPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LogPage.php
@@ -86,13 +86,10 @@
8787 }
8888 # Notify external application via UDP.
8989 # We send this to IRC but do not want to add it the RC table.
90 - global $wgRC2UDPAddress, $wgRC2UDPOmitBots;
9190 $titleObj = SpecialPage::getTitleFor( 'Log', $this->type );
9291 $rc = RecentChange::newLogEntry( $now, $titleObj, $this->doer, $this->getRcComment(), '',
9392 $this->type, $this->action, $this->target, $this->comment, $this->params, $newId );
94 - if( $wgRC2UDPAddress && ( !$rc->getAttribute('rc_bot') || !$wgRC2UDPOmitBots ) ) {
95 - RecentChange::sendToUDP( $rc->getIRCLine() );
96 - }
 93+ $rc->notifyRC2UDP();
9794 }
9895 return true;
9996 }

Status & tagging log