r45688 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r45687‎ | r45688 | r45689 >
Date:23:58, 12 January 2009
Author:demon
Status:resolved (Comments)
Tags:
Comment:
Remove this ucfirst() crap. $filtered is already a DB key, so it should've been normalized at Title construction anyway (and if it wasn't, that's Title's fault). Fwiw: we're throwing a dismissable error every time $wgCapitalLinks is enabled and a lowercase name is submitted. Why bother? We handle this silently everywhere else...
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUpload.php
——@@ -508,11 +508,6 @@
509509 $warning .= '<li>'.wfMsgHtml( 'badfilename', htmlspecialchars( $this->mDestName ) ).'</li>';
510510 }
511511
512 - global $wgCapitalLinks;
513 - if( $wgCapitalLinks ) {
514 - $filtered = ucfirst( $filtered );
515 - }
516 -
517512 global $wgCheckFileExtensions;
518513 if ( $wgCheckFileExtensions ) {
519514 if ( !$this->checkFileExtension( $finalExt, $wgFileExtensions ) ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r45744Followup to r45676, r45688, r45689, but this time actually working. :)...brion19:56, 14 January 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   19:52, 14 January 2009

This was followed up in r45689, but that doesn't actually work. :)

#Comment by Brion VIBBER (talk | contribs)   19:58, 14 January 2009

Made actually working in r45744.

Status & tagging log