r45389 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45388‎ | r45389 | r45390 >
Date:09:39, 4 January 2009
Author:aaron
Status:reverted (Comments)
Tags:
Comment:
Disallow broken Talk:File:x type titles (bug 5280)
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -2072,7 +2072,12 @@
20732073 if ( $ns = $wgContLang->getNsIndex( $p )) {
20742074 # Ordinary namespace
20752075 $dbkey = $m[2];
 2076+ # Disallow Talk:File:x type titles...
 2077+ if( $this->mNamespace == NS_TALK && $ns > 0 )
 2078+ return false; // bug 5280 title issues
20762079 $this->mNamespace = $ns;
 2080+ if( $ns == NS_TALK && $firstPass )
 2081+ continue; # Do another namespace split...
20772082 } elseif( Interwiki::isValidInterwiki( $p ) ) {
20782083 if( !$firstPass ) {
20792084 # Can't make a local interwiki link to an interwiki link.

Follow-up revisions

RevisionCommit summaryAuthorDate
r45479Revert r45389 "Disallow broken Talk:File:x type titles (bug 5280)"...brion02:55, 7 January 2009
r45780Redid r45389 "Disallow broken Talk:File:x type titles (bug 5280)"aaron18:36, 15 January 2009
r111085(bug 28936, bug 5280) Broken or invalid titles can't be removed from watchlis...maxsem20:39, 9 February 2012

Comments

#Comment by Brion VIBBER (talk | contribs)   02:56, 7 January 2009

This is doing really weird things, like normalizing 'Talk:Wikipedia:Foo' to 'Wikipedia:Talk:Foo' which then redirects me to 'Talk:Foo' at Wikipedia.

Need to create some test cases for this if it's redone.

Reverted in r45479

Status & tagging log