r45390 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r45389‎ | r45390 | r45391 >
Date:10:47, 4 January 2009
Author:raymond
Status:resolved (Comments)
Tags:
Comment:
Use new message 'ellipsis'
Note: two calls of $wgLang->truncate() in CodeRevisionListView::formatValue and SpecialCode:messageFragment not touched.
Should be changed altogether per http://lists.wikimedia.org/pipermail/wikitech-l/2008-December/040796.html
Modified paths:
  • /trunk/extensions/CodeReview/CodeCommentsListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeCommentsListView.php
——@@ -90,7 +90,7 @@
9191 $preview = $wgLang->truncate( $text, 300 );
9292 if( strlen($preview) < strlen($text) ) {
9393 $preview = substr( $preview, 0, strrpos($preview,' ') );
94 - $preview .= " . . .";
 94+ $preview .= ' ' . wfMsgForContent( 'ellipsis' );
9595 }
9696 return $preview;
9797 case 'cc_timestamp':

Follow-up revisions

RevisionCommit summaryAuthorDate
r45480Cleanup r45390:...brion03:05, 7 January 2009

Comments

#Comment by Simetrical (talk | contribs)   18:59, 4 January 2009

I don't think the space here is correct. The 'ellipsis' message should contain a space if appropriate (which it's not, in English, if you use the Unicode ellipsis character).

#Comment by Brion VIBBER (talk | contribs)   03:06, 7 January 2009

Cleaned up a bit in r45480. Removed the 'ellipsis' message use since it's not used elsewhere in this module (extra dependency without general use, why bother? :)

Status & tagging log