r45479 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r45478‎ | r45479 | r45480 >
Date:02:55, 7 January 2009
Author:brion
Status:ok
Tags:
Comment:
Revert r45389 "Disallow broken Talk:File:x type titles (bug 5280)"

This is doing really weird things, like normalizing 'Talk:Wikipedia:Foo' to 'Wikipedia:Talk:Foo' which then redirects me to 'Talk:Foo' at Wikipedia.

Need to create some test cases for this if it's redone.
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
——@@ -2076,12 +2076,7 @@
20772077 if ( $ns = $wgContLang->getNsIndex( $p )) {
20782078 # Ordinary namespace
20792079 $dbkey = $m[2];
2080 - # Disallow Talk:File:x type titles...
2081 - if( $this->mNamespace == NS_TALK && $ns > 0 )
2082 - return false; // bug 5280 title issues
20832080 $this->mNamespace = $ns;
2084 - if( $ns == NS_TALK && $firstPass )
2085 - continue; # Do another namespace split...
20862081 } elseif( Interwiki::isValidInterwiki( $p ) ) {
20872082 if( !$firstPass ) {
20882083 # Can't make a local interwiki link to an interwiki link.

Follow-up revisions

RevisionCommit summaryAuthorDate
r45780Redid r45389 "Disallow broken Talk:File:x type titles (bug 5280)"aaron18:36, 15 January 2009
r111085(bug 28936, bug 5280) Broken or invalid titles can't be removed from watchlis...maxsem20:39, 9 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45389Disallow broken Talk:File:x type titles (bug 5280)aaron09:39, 4 January 2009

Status & tagging log