r45346 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45345‎ | r45346 | r45347 >
Date:21:31, 2 January 2009
Author:aaron
Status:reverted (Comments)
Tags:
Comment:
(bug 16433) Special:UnwatchedPages should list unwatched pages in the content namespace(s)
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUnwatchedpages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUnwatchedpages.php
@@ -20,9 +20,11 @@
2121 function isSyndicated() { return false; }
2222
2323 function getSQL() {
 24+ global $wgContentNamespaces;
2425 $dbr = wfGetDB( DB_SLAVE );
2526 list( $page, $watchlist ) = $dbr->tableNamesN( 'page', 'watchlist' );
26 - $mwns = NS_MEDIAWIKI;
 27+ $content = implode(',',$wgContentNamespaces);
 28+ $content = $content ? $content : NS_MAIN;
2729 return
2830 "
2931 SELECT
@@ -32,7 +34,7 @@
3335 page_namespace as value
3436 FROM $page
3537 LEFT JOIN $watchlist ON wl_namespace = page_namespace AND page_title = wl_title
36 - WHERE wl_title IS NULL AND page_is_redirect = 0 AND page_namespace<>$mwns
 38+ WHERE wl_title IS NULL AND page_is_redirect = 0 AND page_namespace IN ($content)
3739 ";
3840 }
3941

Follow-up revisions

RevisionCommit summaryAuthorDate
r45472Reverting r45346 "(bug 16433) Special:UnwatchedPages should list unwatched pa...brion00:19, 7 January 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   00:19, 7 January 2009

I believe the reason for this special page is to help watch for vandalism on pages that no user is watching. Vandalism isn't just something that happens in content namespaces...

Reverted in r45472

Status & tagging log