r45472 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45471‎ | r45472 | r45473 >
Date:00:19, 7 January 2009
Author:brion
Status:ok
Tags:
Comment:
Reverting r45346 "(bug 16433) Special:UnwatchedPages should list unwatched pages in the content namespace(s)"

I believe the reason for this special page is to help watch for vandalism on pages that no user is watching. Vandalism isn't just something that happens in content namespaces...
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUnwatchedpages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUnwatchedpages.php
@@ -20,11 +20,9 @@
2121 function isSyndicated() { return false; }
2222
2323 function getSQL() {
24 - global $wgContentNamespaces;
2524 $dbr = wfGetDB( DB_SLAVE );
2625 list( $page, $watchlist ) = $dbr->tableNamesN( 'page', 'watchlist' );
27 - $content = implode(',',$wgContentNamespaces);
28 - $content = $content ? $content : NS_MAIN;
 26+ $mwns = NS_MEDIAWIKI;
2927 return
3028 "
3129 SELECT
@@ -34,7 +32,7 @@
3533 page_namespace as value
3634 FROM $page
3735 LEFT JOIN $watchlist ON wl_namespace = page_namespace AND page_title = wl_title
38 - WHERE wl_title IS NULL AND page_is_redirect = 0 AND page_namespace IN ($content)
 36+ WHERE wl_title IS NULL AND page_is_redirect = 0 AND page_namespace<>$mwns
3937 ";
4038 }
4139

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45346(bug 16433) Special:UnwatchedPages should list unwatched pages in the content...aaron21:31, 2 January 2009

Status & tagging log