r45347 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r45346‎ \| r45347 \| r45348 >
Date:	21:32, 2 January 2009
Author:	aaron
Status:	ok (Comments)
Tags:
Comment:	(bug 16429) "nominornewtalk" should not trigger e-mail notifications
Modified paths:	/trunk/phase3/includes/UserMailer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/UserMailer.php
—	—	@@ -342,7 +342,7 @@
343	343
344	344	$userTalkId = false;
345	345
346		~~- if ( (!$minorEdit \|\| $wgEnotifMinorEdits) ) {~~
	346	+ if ( !$minorEdit \|\| ($wgEnotifMinorEdits && !$editor->isAllowed('nominornewtalk') ) ) {
347	347	if ( $wgEnotifUserTalk && $isUserTalkPage ) {
348	348	$targetUser = User::newFromName( $title->getText() );
349	349	if ( !$targetUser \|\| $targetUser->isAnon() ) {

Comments

#Comment by Brion VIBBER (talk | contribs) 00:49, 7 January 2009

Added a note on https://bugzilla.wikimedia.org/show_bug.cgi?id=16429#c3 about this... probably the right way to handle it for now, though.

Status & tagging log

00:49, 7 January 2009 Brion VIBBER (talk | contribs) changed the status of r45347 [removed: new added: ok]