r45259 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45258‎ | r45259 | r45260 >
Date:22:12, 31 December 2008
Author:brion
Status:ok
Tags:
Comment:
Revert r45197 "* Enable image moving by default. All known serious issues seem to be fixed."
Don't want to do this just yet, we're in the middle of testing things.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/Title.php (modified) (history)
  • /trunk/phase3/includes/User.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -151,7 +151,6 @@
152152 'markbotedits',
153153 'minoredit',
154154 'move',
155 - 'movepage',
156155 'move-rootuserpages',
157156 'move-subpages',
158157 'nominornewtalk',
Index: trunk/phase3/includes/Title.php
@@ -1222,10 +1222,6 @@
12231223 // Show user page-specific message only if the user can move other pages
12241224 $errors[] = array( 'cant-move-user-page' );
12251225 }
1226 - // Check if user is allowed to move files if it's a file
1227 - if( $this->getNamespace() == NS_FILE && !$user->isAllowed( 'movefile' ) ) {
1228 - $errors[] = array( 'movenotallowedfile' );
1229 - }
12301226 // Check for immobile pages
12311227 if( !MWNamespace::isMovable( $this->getNamespace() ) ) {
12321228 // Specific message for this case
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1163,42 +1163,41 @@
11641164 $wgGroupPermissions = array();
11651165
11661166 // Implicit group for all visitors
1167 -$wgGroupPermissions['*']['createaccount'] = true;
1168 -$wgGroupPermissions['*']['read'] = true;
1169 -$wgGroupPermissions['*']['edit'] = true;
1170 -$wgGroupPermissions['*']['createpage'] = true;
1171 -$wgGroupPermissions['*']['createtalk'] = true;
1172 -$wgGroupPermissions['*']['writeapi'] = true;
 1167+$wgGroupPermissions['*' ]['createaccount'] = true;
 1168+$wgGroupPermissions['*' ]['read'] = true;
 1169+$wgGroupPermissions['*' ]['edit'] = true;
 1170+$wgGroupPermissions['*' ]['createpage'] = true;
 1171+$wgGroupPermissions['*' ]['createtalk'] = true;
 1172+$wgGroupPermissions['*' ]['writeapi'] = true;
11731173
11741174 // Implicit group for all logged-in accounts
1175 -$wgGroupPermissions['user']['move'] = true;
1176 -$wgGroupPermissions['user']['move-subpages'] = true;
1177 -$wgGroupPermissions['user']['move-rootuserpages'] = true; // can move root userpages
1178 -//$wgGroupPermissions['user']['movefile'] = true; // Disabled for now due to possible bugs and security concerns
1179 -$wgGroupPermissions['user']['read'] = true;
1180 -$wgGroupPermissions['user']['edit'] = true;
1181 -$wgGroupPermissions['user']['createpage'] = true;
1182 -$wgGroupPermissions['user']['createtalk'] = true;
1183 -$wgGroupPermissions['user']['writeapi'] = true;
1184 -$wgGroupPermissions['user']['upload'] = true;
1185 -$wgGroupPermissions['user']['reupload'] = true;
1186 -$wgGroupPermissions['user']['reupload-shared'] = true;
1187 -$wgGroupPermissions['user']['minoredit'] = true;
1188 -$wgGroupPermissions['user']['purge'] = true; // can use ?action=purge without clicking "ok"
 1175+$wgGroupPermissions['user' ]['move'] = true;
 1176+$wgGroupPermissions['user' ]['move-subpages'] = true;
 1177+$wgGroupPermissions['user' ]['move-rootuserpages'] = true; // can move root userpages
 1178+$wgGroupPermissions['user' ]['read'] = true;
 1179+$wgGroupPermissions['user' ]['edit'] = true;
 1180+$wgGroupPermissions['user' ]['createpage'] = true;
 1181+$wgGroupPermissions['user' ]['createtalk'] = true;
 1182+$wgGroupPermissions['user' ]['writeapi'] = true;
 1183+$wgGroupPermissions['user' ]['upload'] = true;
 1184+$wgGroupPermissions['user' ]['reupload'] = true;
 1185+$wgGroupPermissions['user' ]['reupload-shared'] = true;
 1186+$wgGroupPermissions['user' ]['minoredit'] = true;
 1187+$wgGroupPermissions['user' ]['purge'] = true; // can use ?action=purge without clicking "ok"
11891188
11901189 // Implicit group for accounts that pass $wgAutoConfirmAge
11911190 $wgGroupPermissions['autoconfirmed']['autoconfirmed'] = true;
11921191
11931192 // Users with bot privilege can have their edits hidden
11941193 // from various log pages by default
1195 -$wgGroupPermissions['bot']['bot'] = true;
1196 -$wgGroupPermissions['bot']['autoconfirmed'] = true;
1197 -$wgGroupPermissions['bot']['nominornewtalk'] = true;
1198 -$wgGroupPermissions['bot']['autopatrol'] = true;
1199 -$wgGroupPermissions['bot']['suppressredirect'] = true;
1200 -$wgGroupPermissions['bot']['apihighlimits'] = true;
1201 -$wgGroupPermissions['bot']['writeapi'] = true;
1202 -#$wgGroupPermissions['bot']['editprotected'] = true; // can edit all protected pages without cascade protection enabled
 1194+$wgGroupPermissions['bot' ]['bot'] = true;
 1195+$wgGroupPermissions['bot' ]['autoconfirmed'] = true;
 1196+$wgGroupPermissions['bot' ]['nominornewtalk'] = true;
 1197+$wgGroupPermissions['bot' ]['autopatrol'] = true;
 1198+$wgGroupPermissions['bot' ]['suppressredirect'] = true;
 1199+$wgGroupPermissions['bot' ]['apihighlimits'] = true;
 1200+$wgGroupPermissions['bot' ]['writeapi'] = true;
 1201+#$wgGroupPermissions['bot' ]['editprotected'] = true; // can edit all protected pages without cascade protection enabled
12031202
12041203 // Most extra permission abilities go to this group
12051204 $wgGroupPermissions['sysop']['block'] = true;
@@ -1232,7 +1231,6 @@
12331232 $wgGroupPermissions['sysop']['apihighlimits'] = true;
12341233 $wgGroupPermissions['sysop']['browsearchive'] = true;
12351234 $wgGroupPermissions['sysop']['noratelimit'] = true;
1236 -$wgGroupPermissions['sysop']['movefile'] = true;
12371235 #$wgGroupPermissions['sysop']['mergehistory'] = true;
12381236
12391237 // Permission to change users' group assignments
@@ -1670,8 +1668,8 @@
16711669 */
16721670 $wgEnableImageWhitelist = true;
16731671
1674 -/** Allows to move images and other media files */
1675 -$wgAllowImageMoving = true;
 1672+/** Allows to move images and other media files. Experemintal, not sure if it always works */
 1673+$wgAllowImageMoving = false;
16761674
16771675 /** Disable database-intensive features */
16781676 $wgMiserMode = false;
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1620,7 +1620,6 @@
16211621 'right-move' => 'Move pages',
16221622 'right-move-subpages' => 'Move pages with their subpages',
16231623 'right-move-rootuserpages' => 'Move root user pages',
1624 -'right-movefile' => 'Move files',
16251624 'right-suppressredirect' => 'Not create a redirect from the old name when moving a page',
16261625 'right-upload' => 'Upload files',
16271626 'right-reupload' => 'Overwrite an existing file',
@@ -2691,7 +2690,6 @@
26922691 'movenologin' => 'Not logged in',
26932692 'movenologintext' => 'You must be a registered user and [[Special:UserLogin|logged in]] to move a page.',
26942693 'movenotallowed' => 'You do not have permission to move pages.',
2695 -'movenotallowedfile' => 'You do not have permission to move files.',
26962694 'cant-move-user-page' => 'You do not have permission to move user pages (apart from subpages).',
26972695 'cant-move-to-user-page' => 'You do not have permission to move a page to a user page (except to a user subpage).',
26982696 'newtitle' => 'To new title:',
Index: trunk/phase3/RELEASE-NOTES
@@ -255,7 +255,6 @@
256256 * Show subversion too even if a "normal" version number is available
257257 * (bug 16121) Add a note that a page move was without creating a redirect in the
258258 move log
259 -* Image moving is now enabled for sysops by default
260259
261260 === Bug fixes in 1.14 ===
262261

Follow-up revisions

RevisionCommit summaryAuthorDate
r45260Revert r45210 for incomplete revert in r45259 of r45197siebrand22:18, 31 December 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45197* Enable image moving by default. All known serious issues seem to be fixed....vasilievvv19:02, 30 December 2008

Status & tagging log