r45258 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45257‎ | r45258 | r45259 >
Date:22:06, 31 December 2008
Author:brion
Status:ok
Tags:
Comment:
Revert r45191 "* (bug 14117) Image redirects from the shared repo now show "redirected from""
Seems to be bizarrely adding a "redirected from" subtitle to *every* shared image page view, instead of to redirects. WTF?
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/ImagePage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ImagePage.php
@@ -107,11 +107,6 @@
108108 $wgOut->setRobotPolicy( 'noindex,nofollow' );
109109 $wgOut->setPageTitle( $this->mTitle->getPrefixedText() );
110110 $this->viewUpdates();
111 -
112 - # And also show "redirected from" message
113 - $sk = $wgUser->getSkin();
114 - $redir = $sk->makeKnownLinkObj( $this->mRedirectedFrom, '', 'redirect=no' );
115 - $wgOut->setSubtitle( wfMsgExt( 'redirectedfrom', array( 'parseinline', 'replaceafter' ), $redir ) );
116111 }
117112
118113 # Show shared description, if needed
Index: trunk/phase3/RELEASE-NOTES
@@ -461,7 +461,6 @@
462462 file extension (e.g. Foo. jpg).
463463 * Ensure that all HTML id's begin with a letter as required by XHTML standard
464464 * Image moving over an existing file no longer throws a database error
465 -* (bug 14117) Image redirects from the shared repo now show "redirected from"
466465 * (bug 16786) Restored "redundant" links recently removed from Classic sidebar
467466
468467

Follow-up revisions

RevisionCommit summaryAuthorDate
r56893(bug 14117) "redirected" from is now also shown on foreign file redirectsbtongminh20:46, 24 September 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45191* (bug 14117) Image redirects from the shared repo now show "redirected from"vasilievvv17:17, 30 December 2008

Status & tagging log