r45197 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45196‎ | r45197 | r45198 >
Date:19:02, 30 December 2008
Author:vasilievvv
Status:reverted (Comments)
Tags:
Comment:
* Enable image moving by default. All known serious issues seem to be fixed.
* Create "movefile" permission
* Restrict image moving to sysops till we are absolutely sure it works correctly.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/Title.php (modified) (history)
  • /trunk/phase3/includes/User.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -151,6 +151,7 @@
152152 'markbotedits',
153153 'minoredit',
154154 'move',
 155+ 'movepage',
155156 'move-rootuserpages',
156157 'move-subpages',
157158 'nominornewtalk',
Index: trunk/phase3/includes/Title.php
@@ -1222,6 +1222,10 @@
12231223 // Show user page-specific message only if the user can move other pages
12241224 $errors[] = array( 'cant-move-user-page' );
12251225 }
 1226+ // Check if user is allowed to move files if it's a file
 1227+ if( $this->getNamespace() == NS_FILE && !$user->isAllowed( 'movefile' ) ) {
 1228+ $errors[] = array( 'movenotallowedfile' );
 1229+ }
12261230 // Check for immobile pages
12271231 if( !MWNamespace::isMovable( $this->getNamespace() ) ) {
12281232 // Specific message for this case
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1163,41 +1163,42 @@
11641164 $wgGroupPermissions = array();
11651165
11661166 // Implicit group for all visitors
1167 -$wgGroupPermissions['*' ]['createaccount'] = true;
1168 -$wgGroupPermissions['*' ]['read'] = true;
1169 -$wgGroupPermissions['*' ]['edit'] = true;
1170 -$wgGroupPermissions['*' ]['createpage'] = true;
1171 -$wgGroupPermissions['*' ]['createtalk'] = true;
1172 -$wgGroupPermissions['*' ]['writeapi'] = true;
 1167+$wgGroupPermissions['*']['createaccount'] = true;
 1168+$wgGroupPermissions['*']['read'] = true;
 1169+$wgGroupPermissions['*']['edit'] = true;
 1170+$wgGroupPermissions['*']['createpage'] = true;
 1171+$wgGroupPermissions['*']['createtalk'] = true;
 1172+$wgGroupPermissions['*']['writeapi'] = true;
11731173
11741174 // Implicit group for all logged-in accounts
1175 -$wgGroupPermissions['user' ]['move'] = true;
1176 -$wgGroupPermissions['user' ]['move-subpages'] = true;
1177 -$wgGroupPermissions['user' ]['move-rootuserpages'] = true; // can move root userpages
1178 -$wgGroupPermissions['user' ]['read'] = true;
1179 -$wgGroupPermissions['user' ]['edit'] = true;
1180 -$wgGroupPermissions['user' ]['createpage'] = true;
1181 -$wgGroupPermissions['user' ]['createtalk'] = true;
1182 -$wgGroupPermissions['user' ]['writeapi'] = true;
1183 -$wgGroupPermissions['user' ]['upload'] = true;
1184 -$wgGroupPermissions['user' ]['reupload'] = true;
1185 -$wgGroupPermissions['user' ]['reupload-shared'] = true;
1186 -$wgGroupPermissions['user' ]['minoredit'] = true;
1187 -$wgGroupPermissions['user' ]['purge'] = true; // can use ?action=purge without clicking "ok"
 1175+$wgGroupPermissions['user']['move'] = true;
 1176+$wgGroupPermissions['user']['move-subpages'] = true;
 1177+$wgGroupPermissions['user']['move-rootuserpages'] = true; // can move root userpages
 1178+//$wgGroupPermissions['user']['movefile'] = true; // Disabled for now due to possible bugs and security concerns
 1179+$wgGroupPermissions['user']['read'] = true;
 1180+$wgGroupPermissions['user']['edit'] = true;
 1181+$wgGroupPermissions['user']['createpage'] = true;
 1182+$wgGroupPermissions['user']['createtalk'] = true;
 1183+$wgGroupPermissions['user']['writeapi'] = true;
 1184+$wgGroupPermissions['user']['upload'] = true;
 1185+$wgGroupPermissions['user']['reupload'] = true;
 1186+$wgGroupPermissions['user']['reupload-shared'] = true;
 1187+$wgGroupPermissions['user']['minoredit'] = true;
 1188+$wgGroupPermissions['user']['purge'] = true; // can use ?action=purge without clicking "ok"
11881189
11891190 // Implicit group for accounts that pass $wgAutoConfirmAge
11901191 $wgGroupPermissions['autoconfirmed']['autoconfirmed'] = true;
11911192
11921193 // Users with bot privilege can have their edits hidden
11931194 // from various log pages by default
1194 -$wgGroupPermissions['bot' ]['bot'] = true;
1195 -$wgGroupPermissions['bot' ]['autoconfirmed'] = true;
1196 -$wgGroupPermissions['bot' ]['nominornewtalk'] = true;
1197 -$wgGroupPermissions['bot' ]['autopatrol'] = true;
1198 -$wgGroupPermissions['bot' ]['suppressredirect'] = true;
1199 -$wgGroupPermissions['bot' ]['apihighlimits'] = true;
1200 -$wgGroupPermissions['bot' ]['writeapi'] = true;
1201 -#$wgGroupPermissions['bot' ]['editprotected'] = true; // can edit all protected pages without cascade protection enabled
 1195+$wgGroupPermissions['bot']['bot'] = true;
 1196+$wgGroupPermissions['bot']['autoconfirmed'] = true;
 1197+$wgGroupPermissions['bot']['nominornewtalk'] = true;
 1198+$wgGroupPermissions['bot']['autopatrol'] = true;
 1199+$wgGroupPermissions['bot']['suppressredirect'] = true;
 1200+$wgGroupPermissions['bot']['apihighlimits'] = true;
 1201+$wgGroupPermissions['bot']['writeapi'] = true;
 1202+#$wgGroupPermissions['bot']['editprotected'] = true; // can edit all protected pages without cascade protection enabled
12021203
12031204 // Most extra permission abilities go to this group
12041205 $wgGroupPermissions['sysop']['block'] = true;
@@ -1231,6 +1232,8 @@
12321233 $wgGroupPermissions['sysop']['apihighlimits'] = true;
12331234 $wgGroupPermissions['sysop']['browsearchive'] = true;
12341235 $wgGroupPermissions['sysop']['noratelimit'] = true;
 1236+$wgGroupPermissions['sysop']['nuke'] = true;
 1237+$wgGroupPermissions['sysop']['movefile'] = true;
12351238 #$wgGroupPermissions['sysop']['mergehistory'] = true;
12361239
12371240 // Permission to change users' group assignments
@@ -1669,8 +1672,8 @@
16701673 */
16711674 $wgEnableImageWhitelist = true;
16721675
1673 -/** Allows to move images and other media files. Experemintal, not sure if it always works */
1674 -$wgAllowImageMoving = false;
 1676+/** Allows to move images and other media files */
 1677+$wgAllowImageMoving = true;
16751678
16761679 /** Disable database-intensive features */
16771680 $wgMiserMode = false;
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1621,6 +1621,7 @@
16221622 'right-move' => 'Move pages',
16231623 'right-move-subpages' => 'Move pages with their subpages',
16241624 'right-move-rootuserpages' => 'Move root user pages',
 1625+'right-movefile' => 'Move files',
16251626 'right-suppressredirect' => 'Not create a redirect from the old name when moving a page',
16261627 'right-upload' => 'Upload files',
16271628 'right-reupload' => 'Overwrite an existing file',
@@ -2731,6 +2732,7 @@
27322733 'movenologin' => 'Not logged in',
27332734 'movenologintext' => 'You must be a registered user and [[Special:UserLogin|logged in]] to move a page.',
27342735 'movenotallowed' => 'You do not have permission to move pages.',
 2736+'movenotallowedfile' => 'You do not have permission to move files.',
27352737 'cant-move-user-page' => 'You do not have permission to move user pages (apart from subpages).',
27362738 'cant-move-to-user-page' => 'You do not have permission to move a page to a user page (except to a user subpage).',
27372739 'newtitle' => 'To new title:',
Index: trunk/phase3/RELEASE-NOTES
@@ -257,6 +257,7 @@
258258 * Show subversion too even if a "normal" version number is available
259259 * (bug 16121) Add a note that a page move was without creating a redirect in the
260260 move log
 261+* Image moving is now enabled for sysops by default
261262
262263 === Bug fixes in 1.14 ===
263264

Follow-up revisions

RevisionCommit summaryAuthorDate
r45259Revert r45197 "* Enable image moving by default. All known serious issues see...brion22:12, 31 December 2008
r45260Revert r45210 for incomplete revert in r45259 of r45197siebrand22:18, 31 December 2008

Comments

#Comment by VasilievVV (talk | contribs)   20:50, 31 December 2008

Needs to be fixed in Wikimedia config though.

#Comment by Brion VIBBER (talk | contribs)   22:12, 31 December 2008

Reverted in r45259. We're in the middle of testing things and I don't want features enabling themselves.

Status & tagging log