r45191 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45190‎ | r45191 | r45192 >
Date:17:17, 30 December 2008
Author:vasilievvv
Status:reverted (Comments)
Tags:
Comment:
* (bug 14117) Image redirects from the shared repo now show "redirected from"
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/ImagePage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ImagePage.php
@@ -107,6 +107,11 @@
108108 $wgOut->setRobotPolicy( 'noindex,nofollow' );
109109 $wgOut->setPageTitle( $this->mTitle->getPrefixedText() );
110110 $this->viewUpdates();
 111+
 112+ # And also show "redirected from" message
 113+ $sk = $wgUser->getSkin();
 114+ $redir = $sk->makeKnownLinkObj( $this->mRedirectedFrom, '', 'redirect=no' );
 115+ $wgOut->setSubtitle( wfMsgExt( 'redirectedfrom', array( 'parseinline', 'replaceafter' ), $redir ) );
111116 }
112117
113118 # Show shared description, if needed
Index: trunk/phase3/RELEASE-NOTES
@@ -460,6 +460,7 @@
461461 file extension (e.g. Foo. jpg).
462462 * Ensure that all HTML id's begin with a letter as required by XHTML standard
463463 * Image moving over an existing file no longer throws a database error
 464+* (bug 14117) Image redirects from the shared repo now show "redirected from"
464465
465466 === API changes in 1.14 ===
466467

Follow-up revisions

RevisionCommit summaryAuthorDate
r45258Revert r45191 "* (bug 14117) Image redirects from the shared repo now show "r...brion22:06, 31 December 2008
r56893(bug 14117) "redirected" from is now also shown on foreign file redirectsbtongminh20:46, 24 September 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   22:06, 31 December 2008

Reverted in r45258

Seems to be bizarrely adding a "redirected from" subtitle to *every* shared image page view, instead of to redirects. WTF?

Status & tagging log