r45257 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45256‎ | r45257 | r45258 >
Date:21:31, 31 December 2008
Author:brion
Status:ok
Tags:
Comment:
* (bug 16786) Restored "redundant" links recently removed from Classic sidebar
Reverted r44780, r44788
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/skins/Standard.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Standard.php
@@ -227,6 +227,10 @@
228228 # "Post a comment" link
229229 if( ( $wgTitle->isTalkPage() || $wgOut->showNewSectionLink() ) && $action != 'edit' && !$wpPreview )
230230 $s .= '<br />' . $this->makeKnownLinkObj( $wgTitle, wfMsg( 'postcomment' ), 'action=edit&section=new' );
 231+
 232+ #if( $tns%2 && $action!='edit' && !$wpPreview) {
 233+ #$s.= '<br />'.$this->makeKnownLink($wgTitle->getPrefixedText(),wfMsg('postcomment'),'action=edit&section=new');
 234+ #}
231235
232236 /*
233237 watching could cause problems in edit mode:
@@ -250,7 +254,12 @@
251255 if ($articleExists && $action !='history') {
252256 $s .= $sep . $this->historyLink();
253257 }
 258+ $s.=$sep . $this->whatLinksHere();
254259
 260+ if($wgOut->isArticleRelated()) {
 261+ $s .= $sep . $this->watchPageLinksLink();
 262+ }
 263+
255264 if ( NS_USER == $wgTitle->getNamespace()
256265 || $wgTitle->getNamespace() == NS_USER_TALK ) {
257266
Index: trunk/phase3/includes/Skin.php
@@ -1160,11 +1160,15 @@
11611161 global $wgOut;
11621162 $sep = " |\n";
11631163
1164 - $s = $this->mainPageLink();
 1164+ $s = $this->mainPageLink() . $sep
 1165+ . $this->specialLink( 'recentchanges' );
11651166
11661167 if ( $wgOut->isArticleRelated() ) {
1167 - $s .= $sep . $this->editThisPage() . $sep . $this->historyLink();
 1168+ $s .= $sep . $this->editThisPage()
 1169+ . $sep . $this->historyLink();
11681170 }
 1171+ # Many people don't like this dropdown box
 1172+ #$s .= $sep . $this->specialPagesList();
11691173
11701174 $s .= $this->variantLinks();
11711175
Index: trunk/phase3/RELEASE-NOTES
@@ -462,7 +462,9 @@
463463 * Ensure that all HTML id's begin with a letter as required by XHTML standard
464464 * Image moving over an existing file no longer throws a database error
465465 * (bug 14117) Image redirects from the shared repo now show "redirected from"
 466+* (bug 16786) Restored "redundant" links recently removed from Classic sidebar
466467
 468+
467469 === API changes in 1.14 ===
468470
469471 * Registration time of users registered before the DB field was created is now

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r44780Remove some less-useful redundant links from sidebaraaron20:50, 18 December 2008
r44788Streamline links a bitaaron23:09, 18 December 2008

Status & tagging log