r45190 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45189‎ | r45190 | r45191 >
Date:16:12, 30 December 2008
Author:raymond
Status:ok
Tags:
Comment:
Show subversion too even if a "normal" version number is available
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialVersion.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialVersion.php
@@ -157,17 +157,23 @@
158158 usort( $wgExtensionCredits[$type], array( $this, 'compare' ) );
159159
160160 foreach ( $wgExtensionCredits[$type] as $extension ) {
 161+ $version = null;
 162+ $subVersion = '';
161163 if ( isset( $extension['version'] ) ) {
162164 $version = $extension['version'];
163 - } elseif ( isset( $extension['svn-revision'] ) &&
 165+ }
 166+ if ( isset( $extension['svn-revision'] ) &&
164167 preg_match( '/\$(?:Rev|LastChangedRevision|Revision): *(\d+)/',
165 - $extension['svn-revision'], $m ) )
166 - {
167 - $version = 'r' . $m[1];
168 - } else {
169 - $version = null;
 168+ $extension['svn-revision'], $m ) ) {
 169+ $subVersion = 'r' . $m[1];
170170 }
171171
 172+ if( $version && $subVersion ) {
 173+ $version = $version . ' [' . $subVersion . ']';
 174+ } elseif ( !$version && $subVersion ) {
 175+ $version = $subVersion;
 176+ }
 177+
172178 $out .= $this->formatCredits(
173179 isset ( $extension['name'] ) ? $extension['name'] : '',
174180 $version,
Index: trunk/phase3/RELEASE-NOTES
@@ -254,6 +254,7 @@
255255 * (bug 16754) Making arbitrary rows of sortable tables sticky:
256256 |- class="unsortable"
257257 * (bug 16617) Add "talk" link to list of templates in edit mode
 258+* Show subversion too even if a "normal" version number is available
258259
259260 === Bug fixes in 1.14 ===
260261

Status & tagging log