r45063 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45062‎ | r45063 | r45064 >
Date:05:09, 27 December 2008
Author:aaron
Status:reverted (Comments)
Tags:
Comment:
Move doNothing return check above global declarations
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -798,16 +798,13 @@
799799 * the object, let's actually output it:
800800 */
801801 public function output() {
 802+ if( $this->mDoNothing ) return;
802803 global $wgUser, $wgOutputEncoding, $wgRequest;
803804 global $wgContLanguageCode, $wgDebugRedirects, $wgMimeType;
804805 global $wgJsMimeType, $wgUseAjax, $wgAjaxWatch;
805806 global $wgEnableMWSuggest, $wgUniversalEditButton;
806807 global $wgArticle, $wgTitle;
807808
808 - if( $this->mDoNothing ){
809 - return;
810 - }
811 -
812809 wfProfileIn( __METHOD__ );
813810
814811 if ( '' != $this->mRedirect ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r45233Revert r45063 "Move doNothing return check above global declarations"...brion17:56, 31 December 2008

Comments

#Comment by Brion VIBBER (talk | contribs)   17:56, 31 December 2008

Reverted in r45233 -- makes the code harder to read by hiding a control statement in the middle of a global declaration block.

Status & tagging log