r45064 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45063‎ | r45064 | r45065 >
Date:05:17, 27 December 2008
Author:demon
Status:deferred (Comments)
Tags:
Comment:
Cleanup to r45062 (add Interwiki extension to core)
* If we're going to extend SpecialPage, actually do it. Don't use this wfSpecialSomething() crap.
* Clean up descriptions of Local/Trans. Most people don't know what Local/Trans mean for interwikis (I don't 100% get iw_local)
Modified paths:
  • /trunk/phase3/includes/SpecialPage.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialInterwiki.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialInterwiki.php
@@ -1,16 +1,6 @@
22 <?php
33
44 /**
5 - * Constructor
6 - */
7 -function wfSpecialInterwiki( $par ) {
8 - global $wgRequest;
9 -
10 - $form = new SpecialInterwiki( $wgRequest, $par );
11 - $form->execute();
12 -}
13 -
14 -/**
155 * implements Special:Interwiki
166 * @ingroup SpecialPage
177 */
Index: trunk/phase3/includes/SpecialPage.php
@@ -147,7 +147,7 @@
148148 'Blockip' => array( 'SpecialPage', 'Blockip', 'block' ),
149149 'Undelete' => array( 'SpecialPage', 'Undelete', 'deletedhistory' ),
150150 'Import' => 'SpecialImport',
151 - 'Interwiki' => array( 'SpecialPage', 'Interwiki' ),
 151+ 'Interwiki' => 'SpecialInterwiki',
152152 'Lockdb' => array( 'SpecialPage', 'Lockdb', 'siteadmin' ),
153153 'Unlockdb' => array( 'SpecialPage', 'Unlockdb', 'siteadmin' ),
154154 'Userrights' => 'UserrightsPage',
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2197,8 +2197,8 @@
21982198 There is a [[Special:Log/interwiki|log of changes]] to the interwiki table.',
21992199 'interwiki_prefix' => 'Prefix',
22002200 'interwiki_url' => 'URL',
2201 -'interwiki_local' => 'Local',
2202 -'interwiki_trans' => 'Trans',
 2201+'interwiki_local' => 'Define this as a local wiki', # needs a better description. Exactly _what_ does iw_local mean?
 2202+'interwiki_trans' => 'Allow interwiki transclusions',
22032203 'interwiki_error' => 'Error: The interwiki table is empty, or something else went wrong.',
22042204 'interwiki_delquestion' => 'Deleting "$1"',
22052205 'interwiki_deleting' => 'You are deleting prefix "$1".',

Follow-up revisions

RevisionCommit summaryAuthorDate
r45069Update messages per r45064siebrand07:47, 27 December 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45062Add Interwiki extension to core.soxred9305:00, 27 December 2008

Comments

#Comment by Brion VIBBER (talk | contribs)   17:57, 31 December 2008

Changes need to be merged back to the extension and out of core.

#Comment by Siebrand (talk | contribs)   18:55, 31 December 2008

Reverted and merged back into extension in r45238 and r45239.

Status & tagging log