r45233 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45232‎ | r45233 | r45234 >
Date:17:56, 31 December 2008
Author:brion
Status:ok
Tags:
Comment:
Revert r45063 "Move doNothing return check above global declarations"
Change makes the code harder to read by hiding a control statement in the middle of a global declaraction chunk.
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -798,13 +798,16 @@
799799 * the object, let's actually output it:
800800 */
801801 public function output() {
802 - if( $this->mDoNothing ) return;
803802 global $wgUser, $wgOutputEncoding, $wgRequest;
804803 global $wgContLanguageCode, $wgDebugRedirects, $wgMimeType;
805804 global $wgJsMimeType, $wgUseAjax, $wgAjaxWatch;
806805 global $wgEnableMWSuggest, $wgUniversalEditButton;
807806 global $wgArticle, $wgTitle;
808807
 808+ if( $this->mDoNothing ){
 809+ return;
 810+ }
 811+
809812 wfProfileIn( __METHOD__ );
810813
811814 if ( '' != $this->mRedirect ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45063Move doNothing return check above global declarationsaaron05:09, 27 December 2008

Status & tagging log