r42800 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r42799‎ | r42800 | r42801 >
Date:03:32, 30 October 2008
Author:soxred93
Status:old (Comments)
Tags:
Comment:
Add to messages.inc, ignore the <li> if it does not exist, and add to Modern too.
Modified paths:
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)
  • /trunk/phase3/skins/Modern.php (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -213,6 +213,7 @@
214214 'jumpto',
215215 'jumptonavigation',
216216 'jumptosearch',
 217+ 'footermessage',
217218 ),
218219 'links' => array(
219220 'aboutsite',
Index: trunk/phase3/skins/MonoBook.php
@@ -222,9 +222,12 @@
223223 ?> <li id="<?php echo$aLink?>"><?php $this->html($aLink) ?></li>
224224 <?php }
225225 }
 226+ if( !wfEmptyMsg( 'footermessage' ) {
 227+?> <li id="footermessage"><?php $this->msgWiki('footermessage') ?></li>
 228+
 229+<?php }
226230 ?>
227 - <li id="footermessage"><?php $this->msgWiki('footermessage') ?></li>
228 - </ul>
 231+ </ul>
229232 </div>
230233 </div>
231234 <?php $this->html('bottomscripts'); /* JS call to runBodyOnloadHook */ ?>
Index: trunk/phase3/skins/Modern.php
@@ -225,6 +225,10 @@
226226 ?> <li id="<?php echo$aLink?>"><?php $this->html($aLink) ?></li>
227227 <?php }
228228 }
 229+ if( !wfEmptyMsg( 'footermessage' ) {
 230+?> <li id="footermessage"><?php $this->msgWiki('footermessage') ?></li>
 231+
 232+<?php }
229233 ?>
230234 </ul>
231235 <?php echo $this->html("poweredbyico"); ?>

Follow-up revisions

RevisionCommit summaryAuthorDate
r42802Revert r42799, r42800 "(bug 1999) Add editable footer message, via [[MediaWik...brion04:48, 30 October 2008

Comments

#Comment by Brion VIBBER (talk | contribs)   04:49, 30 October 2008

Reverting in r42802 -- wiki parsing of messages can be slow, so we avoid it on every-pageview things like headers and footers.

Status & tagging log