r42802 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r42801‎ | r42802 | r42803 >
Date:04:48, 30 October 2008
Author:brion
Status:old
Tags:
Comment:
Revert r42799, r42800 "(bug 1999) Add editable footer message, via [[MediaWiki:Footermessage]]"
Full wiki parsing of messages is slow, thus not done on every page view on principle (eg sitenotice cache).
Modified paths:
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)
  • /trunk/phase3/skins/Modern.php (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -213,7 +213,6 @@
214214 'jumpto',
215215 'jumptonavigation',
216216 'jumptosearch',
217 - 'footermessage',
218217 ),
219218 'links' => array(
220219 'aboutsite',
Index: trunk/phase3/skins/MonoBook.php
@@ -222,12 +222,8 @@
223223 ?> <li id="<?php echo$aLink?>"><?php $this->html($aLink) ?></li>
224224 <?php }
225225 }
226 - if( !wfEmptyMsg( 'footermessage' ) {
227 -?> <li id="footermessage"><?php $this->msgWiki('footermessage') ?></li>
228 -
229 -<?php }
230226 ?>
231 - </ul>
 227+ </ul>
232228 </div>
233229 </div>
234230 <?php $this->html('bottomscripts'); /* JS call to runBodyOnloadHook */ ?>
Index: trunk/phase3/skins/Modern.php
@@ -225,10 +225,6 @@
226226 ?> <li id="<?php echo$aLink?>"><?php $this->html($aLink) ?></li>
227227 <?php }
228228 }
229 - if( !wfEmptyMsg( 'footermessage' ) {
230 -?> <li id="footermessage"><?php $this->msgWiki('footermessage') ?></li>
231 -
232 -<?php }
233229 ?>
234230 </ul>
235231 <?php echo $this->html("poweredbyico"); ?>
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -701,7 +701,6 @@
702702 'jumpto' => 'Jump to:',
703703 'jumptonavigation' => 'navigation',
704704 'jumptosearch' => 'search',
705 -'footermessage' => '',
706705
707706 # All link text and link target definitions of links into project namespace that get used by other message strings, with the exception of user group pages (see grouppage) and the disambiguation template definition (see disambiguations).
708707 'aboutsite' => 'About {{SITENAME}}',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r42799(bug 1999) Add editable footer message, via [[MediaWiki:Footermessage]]soxred9303:00, 30 October 2008
r42800Add to messages.inc, ignore the <li> if it does not exist, and add to Modern ...soxred9303:32, 30 October 2008

Status & tagging log