r42799 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r42798‎ | r42799 | r42800 >
Date:03:00, 30 October 2008
Author:soxred93
Status:old (Comments)
Tags:
Comment:
(bug 1999) Add editable footer message, via [[MediaWiki:Footermessage]]
Modified paths:
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/MonoBook.php
@@ -223,6 +223,7 @@
224224 <?php }
225225 }
226226 ?>
 227+ <li id="footermessage"><?php $this->msgWiki('footermessage') ?></li>
227228 </ul>
228229 </div>
229230 </div>
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -701,6 +701,7 @@
702702 'jumpto' => 'Jump to:',
703703 'jumptonavigation' => 'navigation',
704704 'jumptosearch' => 'search',
 705+'footermessage' => '',
705706
706707 # All link text and link target definitions of links into project namespace that get used by other message strings, with the exception of user group pages (see grouppage) and the disambiguation template definition (see disambiguations).
707708 'aboutsite' => 'About {{SITENAME}}',

Follow-up revisions

RevisionCommit summaryAuthorDate
r42802Revert r42799, r42800 "(bug 1999) Add editable footer message, via [[MediaWik...brion04:48, 30 October 2008

Comments

#Comment by Brion VIBBER (talk | contribs)   04:49, 30 October 2008

Reverting in r42802 -- wiki parsing of messages can be slow, so we avoid it on every-pageview things like headers and footers.

#Comment by Simetrical (talk | contribs)   16:52, 30 October 2008

Note also that if this is implemented, it needs to be for all skins: admins might depend on the footer contents being visible, which they won't be for anyone using a non-MonoBook skin with this implementation.

Status & tagging log