r41819 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r41818‎ | r41819 | r41820 >
Date:20:14, 7 October 2008
Author:ialex
Status:old (Comments)
Tags:
Comment:
Revert r41792, broke uploads. Note that RepoGroup::findFile() returns false if no file was found, which might be the case when uploading new files ;) (see bug 15883)
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
——@@ -2791,7 +2791,7 @@
27922792 * Returns a valid placeholder object if the file does not exist.
27932793 */
27942794 function wfLocalFile( $title, $time = false ) {
2795 - return RepoGroup::singleton()->getLocalRepo()->findFile( $title, $time );
 2795+ return RepoGroup::singleton()->getLocalRepo()->newFile( $title, $time );
27962796 }
27972797
27982798 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r41792Tweak r41788 - Use findFile() to check current version if $time givenaaron02:22, 7 October 2008

Comments

#Comment by Voice of All (talk | contribs)   21:23, 7 October 2008

newFile() is now broken with $time. I'll fix that.

#Comment by Voice of All (talk | contribs)   21:42, 7 October 2008

Resolved in r41822

Status & tagging log