r41792 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41791‎ | r41792 | r41793 >
Date:02:22, 7 October 2008
Author:aaron
Status:old (Comments)
Tags:
Comment:
Tweak r41788 - Use findFile() to check current version if $time given
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
@@ -2791,7 +2791,7 @@
27922792 * Returns a valid placeholder object if the file does not exist.
27932793 */
27942794 function wfLocalFile( $title, $time = false ) {
2795 - return RepoGroup::singleton()->getLocalRepo()->newFile( $title, $time );
 2795+ return RepoGroup::singleton()->getLocalRepo()->findFile( $title, $time );
27962796 }
27972797
27982798 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r41819Revert r41792, broke uploads. Note that RepoGroup::findFile() returns false i...ialex20:14, 7 October 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r41788Add handy $time parameter to wfLocalFile()aaron00:30, 7 October 2008

Comments

#Comment by IAlex (talk | contribs)   20:18, 7 October 2008

I reverted it in r41819, it broke uploads (bug 15883).

Status & tagging log