r41770 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41769‎ | r41770 | r41771 >
Date:19:13, 6 October 2008
Author:huji
Status:old (Comments)
Tags:
Comment:
(bug 15869) Nostalgia skin does not show page title in printable mode
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/Nostalgia.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Nostalgia.php
@@ -25,12 +25,13 @@
2626
2727 function doBeforeContent() {
2828
29 - $s = "\n<div id='content'>\n<div id='topbar'>";
30 - $s .= $this->logoText( "right" );
 29+ $s .= "\n<div id='content'>\n<div id='top'>\n";
 30+ $s .= "<div id=\"topbar\">".$this->logoText( "right" )."</div>";
3131
3232 $s .= $this->pageTitle();
3333 $s .= $this->pageSubtitle() . "\n";
3434
 35+ $s .= "<div id=\"topbar\">";
3536 $s .= $this->topLinks() . "\n<br />";
3637
3738 $notice = wfGetSiteNotice();
@@ -45,7 +46,7 @@
4647 $cat = $this->getCategoryLinks();
4748 if($cat) $s .= "<br />" . $cat;
4849
49 - $s .= "<br clear='all' /><hr />\n</div>\n";
 50+ $s .= "<br clear='all' /></div><hr />\n</div>\n";
5051 $s .= "\n<div id='article'>";
5152
5253 return $s;
@@ -62,17 +63,17 @@
6364 $s .= $sep . $this->editThisPage()
6465 . $sep . $this->historyLink();
6566 }
66 -
 67+
6768 /* show links to different language variants */
6869 $s .= $this->variantLinks();
6970 $s .= $this->extensionTabLinks();
70 -
 71+
7172 if ( $wgUser->isAnon() ) {
7273 $s .= $sep . $this->specialLink( "userlogin" );
7374 } else {
7475 $s .= $sep . $this->specialLink( "userlogout" );
7576 }
76 -
 77+
7778 $s .= $sep . $this->specialPagesList();
7879
7980 return $s;
Index: trunk/phase3/RELEASE-NOTES
@@ -246,6 +246,7 @@
247247 * Links with no title but a curid parameter now use the curid to pick a page
248248 * (bug 10323) Special:Undelete should have "inverse selection" button
249249 * (bug 15831) Modern skin RTL support is bugous
 250+* (bug 15869) Nostalgia skin does not show page title in printable mode
250251
251252 === API changes in 1.14 ===
252253

Follow-up revisions

RevisionCommit summaryAuthorDate
r41772(sanitizing r41770) An ID can't be used for two elementshuji19:23, 6 October 2008
r41934Fix E_NOTICE from r41770simetrical15:37, 10 October 2008

Comments

#Comment by Huji (talk | contribs)   19:27, 6 October 2008

Sanitized in r41772 to comply with W3C CSS standards

Status & tagging log