r41772 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41771‎ | r41772 | r41773 >
Date:19:23, 6 October 2008
Author:huji
Status:old
Tags:
Comment:
(sanitizing r41770) An ID can't be used for two elements
Modified paths:
  • /trunk/phase3/skins/Nostalgia.php (modified) (history)
  • /trunk/phase3/skins/common/wikiprintable.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/wikiprintable.css
@@ -21,7 +21,7 @@
2222 }
2323
2424 /* Hide ugly UI stuff */
25 -#quickbar, #topbar, #footer, #siteNotice,
 25+#quickbar, #topbar, #logo, #footer, #siteNotice,
2626 .editsection, .toctoggle {
2727 display: none;
2828 }
Index: trunk/phase3/skins/Nostalgia.php
@@ -26,7 +26,7 @@
2727 function doBeforeContent() {
2828
2929 $s .= "\n<div id='content'>\n<div id='top'>\n";
30 - $s .= "<div id=\"topbar\">".$this->logoText( "right" )."</div>";
 30+ $s .= "<div id=\"logo\">".$this->logoText( "right" )."</div>";
3131
3232 $s .= $this->pageTitle();
3333 $s .= $this->pageSubtitle() . "\n";
@@ -46,7 +46,8 @@
4747 $cat = $this->getCategoryLinks();
4848 if($cat) $s .= "<br />" . $cat;
4949
50 - $s .= "<br clear='all' /></div><hr />\n</div>\n";
 50+ $s .= "<br clear='all' /></div><hr />\n</div
 51+>\n";
5152 $s .= "\n<div id='article'>";
5253
5354 return $s;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r41770(bug 15869) Nostalgia skin does not show page title in printable modehuji19:13, 6 October 2008

Status & tagging log