r41769 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41768‎ | r41769 | r41770 >
Date:18:56, 6 October 2008
Author:ialex
Status:old (Comments)
Tags:
Comment:
Fix XHTML error (url not escaped)
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
@@ -1873,8 +1873,8 @@
18741874 wfProfileIn( $fname );
18751875 $siteNotice = '';
18761876 $loggedIn = false;
1877 - $spTitle = SpecialPage::getTitleFor('DismissNotice');
1878 - $spUrl = $spTitle->getFullURL( array( 'returnto' => $wgTitle->getPrefixedURL() ) );
 1877+ $spTitle = SpecialPage::getTitleFor( 'DismissNotice' );
 1878+ $spUrl = $spTitle->escapeFullURL( array( 'returnto' => $wgTitle->getPrefixedURL() ) );
18791879
18801880 if( $wgUser instanceOf User && $wgUser->isLoggedIn() ) {
18811881 $loggedIn = true;

Comments

#Comment by Tim Starling (talk | contribs)   04:49, 11 October 2008

Reverted in r41958.

Status & tagging log