r42769 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r42768‎ | r42769 | r42770 >
Date:15:47, 29 October 2008
Author:aaron
Status:old (Comments)
Tags:
Comment:
Redo r41723: still show rcnotefrom as needed, but not rcnote. Add rclegend message if it is not empty.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialRecentchanges.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRecentchanges.php
@@ -595,17 +595,15 @@
596596
597597 $options = $nondefaults + $defaults;
598598
599 - if( $options['from'] )
600 - $note = wfMsgExt( 'rcnotefrom', array( 'parseinline' ),
 599+ $note = '';
 600+ if( $options['from'] ) {
 601+ $note .= wfMsgExt( 'rcnotefrom', array( 'parseinline' ),
601602 $wgLang->formatNum( $options['limit'] ),
602 - $wgLang->timeanddate( $options['from'], true ) );
603 - else
604 - $note = wfMsgExt( 'rcnote', array( 'parseinline' ),
605 - $wgLang->formatNum( $options['limit'] ),
606 - $wgLang->formatNum( $options['days'] ),
607 - $wgLang->timeAndDate( wfTimestampNow(), true ),
608 - $wgLang->date( wfTimestampNow(), true ),
609 - $wgLang->time( wfTimestampNow(), true ) );
 603+ $wgLang->timeanddate( $options['from'], true ) ) . '<br />';
 604+ }
 605+ if( !wfEmptyMsg( 'rclegend', wfMsg('rclegend') ) ) {
 606+ $note .= wfMsgExt( 'rclegend', array('parseinline') ) . '<br />';
 607+ }
610608
611609 # Sort data for display and make sure it's unique after we've added user data.
612610 $wgRCLinkLimits[] = $options['limit'];
@@ -661,6 +659,6 @@
662660 $rclinks = wfMsgExt( 'rclinks', array( 'parseinline', 'replaceafter' ),
663661 $cl, $dl, $hl );
664662 $rclistfrom = wfMsgExt( 'rclistfrom', array( 'parseinline', 'replaceafter' ), $tl );
665 - return "$note<br />$rclinks<br />$rclistfrom";
 663+ return "{$note}$rclinks<br />$rclistfrom";
666664 }
667665 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r46173* fixing regression from r42769 (component ordering & empty line)danny_b00:19, 25 January 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r41723Remove some redundant "starting from" message cruft (bug 3327)aaron03:49, 6 October 2008

Comments

#Comment by Aaron Schulz (talk | contribs)   23:50, 25 January 2009

Tweaks in r46240 to allow proper floating

Status & tagging log