r40857 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40856‎ | r40857 | r40858 >
Date:15:35, 15 September 2008
Author:aaron
Status:old
Tags:
Comment:
Don't show html in irc feeds. Message should be such that when no $skin is given, there is not html. (bug 15610)
Modified paths:
  • /trunk/extensions/Renameuser/SpecialRenameuser.i18n.php (modified) (history)
  • /trunk/extensions/Renameuser/SpecialRenameuser.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Renameuser/SpecialRenameuser.i18n.php
@@ -34,7 +34,7 @@
3535
3636 'renameuserlogpage' => 'User rename log',
3737 'renameuserlogpagetext' => 'This is a log of changes to user names.',
38 - 'renameuserlogentry' => 'has renamed [[User:$1|$1]] to "[[User:$2|$2]]"',
 38+ 'renameuserlogentry' => 'has renamed $1 to "$2"',
3939 'renameuser-log' => '{{PLURAL:$1|1 edit|$1 edits}}. Reason: $2',
4040 'renameuser-move-log' => 'Automatically moved page while renaming the user "[[User:$1|$1]]" to "[[User:$2|$2]]"',
4141
Index: trunk/extensions/Renameuser/SpecialRenameuser.php
@@ -48,8 +48,11 @@
4949 if( !$title || $title->getNamespace() !== NS_USER ) {
5050 $rv = ''; // handled in comment, the old way
5151 } else {
52 - array_unshift( $params, $title->getText() );
53 - $rv = wfMsgExt( 'renameuserlogentry', array('parseinline'), $params );
 52+ $titleLink = $skin ?
 53+ $skin->makeLinkObj( $title, htmlspecialchars( $title->getPrefixedText() ) ) : $title->getText();
 54+ # Add title to params
 55+ array_unshift( $params, $titleLink );
 56+ $rv = wfMsgReal( 'renameuserlogentry', $params );
5457 }
5558 return $rv;
5659 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r40869Cleanup after r40857.siebrand19:11, 15 September 2008