r40858 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40857‎ | r40858 | r40859 >
Date:15:51, 15 September 2008
Author:aaron
Status:old
Tags:
Comment:
Clean up OldChangesListRecentChangesLine hooks some. Better if triggers before li tag additions.
Modified paths:
  • /trunk/phase3/includes/ChangesList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ChangesList.php
@@ -342,7 +342,7 @@
343343 $dateheader = ""; // $s now contains only <li>...</li>, for hooks' convenience.
344344 $this->insertDateHeader($dateheader,$rc_timestamp);
345345
346 - $s = '<li>';
 346+ $s = '';
347347
348348 // Moved pages
349349 if( $rc_type == RC_MOVE || $rc_type == RC_MOVE_OVER_REDIRECT ) {
@@ -394,10 +394,10 @@
395395 $s .= ' ' . wfMsg('number_of_watching_users_RCview', $wgContLang->formatNum($rc->numberofWatchingusers));
396396 }
397397
398 - $s .= "</li>\n";
 398+ wfRunHooks( 'OldChangesListRecentChangesLine', array(&$this, &$s, $rc) );
 399+
 400+ $s .= "<li>$s</li>\n";
399401
400 - wfRunHooks('OldChangesListRecentChangesLine', array(&$this, &$s, &$rc));
401 -
402402 wfProfileOut( $fname.'-rest' );
403403
404404 wfProfileOut( $fname );

Follow-up revisions

RevisionCommit summaryAuthorDate
r41082Updated customizeOldChangesList in accordance with r40858: no longer insert d...david22:49, 20 September 2008