r40419 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40418‎ | r40419 | r40420 >
Date:06:19, 4 September 2008
Author:tstarling
Status:old
Tags:
Comment:
Fix for bug 13770, second attempt. Tested with a conflicting install of both dom and domxml, as per the report.
Modified paths:
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser.php
@@ -134,6 +134,10 @@
135135 $this->mVarCache = array();
136136 if ( isset( $conf['preprocessorClass'] ) ) {
137137 $this->mPreprocessorClass = $conf['preprocessorClass'];
 138+ } elseif ( extension_loaded( 'domxml' ) ) {
 139+ // PECL extension that conflicts with the core DOM extension (bug 13770)
 140+ wfDebug( "Warning: you have the obsolete domxml extension for PHP. Please remove it!\n" );
 141+ $this->mPreprocessorClass = 'Preprocessor_Hash';
138142 } elseif ( extension_loaded( 'dom' ) ) {
139143 $this->mPreprocessorClass = 'Preprocessor_DOM';
140144 } else {

Follow-up revisions

RevisionCommit summaryAuthorDate
r40422Fix for bug 13770 (backport of r40419)tstarling07:10, 4 September 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r34283* (bug 13770) Use Preprocessor_Hash by default to avoid missing DOM module er...brion00:01, 6 May 2008
r34284* (bug 13770) Use Preprocessor_Hash by default to avoid missing DOM module er...brion00:01, 6 May 2008
r39158Fixed incorrect detection of PHP's DOM module (bug 13770)tstarling17:24, 11 August 2008
r39159Backport r39158: fix for bug 13770: incorrect detection of DOM moduletstarling17:33, 11 August 2008