r39158 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r39157‎ | r39158 | r39159 >
Date:17:24, 11 August 2008
Author:tstarling
Status:old
Tags:
Comment:
Fixed incorrect detection of PHP's DOM module (bug 13770)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser.php
@@ -133,7 +133,7 @@
134134 $this->mVarCache = array();
135135 if ( isset( $conf['preprocessorClass'] ) ) {
136136 $this->mPreprocessorClass = $conf['preprocessorClass'];
137 - } elseif ( class_exists( 'DOMDocument' ) ) {
 137+ } elseif ( extension_loaded( 'dom' ) ) {
138138 $this->mPreprocessorClass = 'Preprocessor_DOM';
139139 } else {
140140 $this->mPreprocessorClass = 'Preprocessor_Hash';
Index: trunk/phase3/RELEASE-NOTES
@@ -103,6 +103,7 @@
104104 WikimediaMessages. Patch for Czech by Danny B.
105105 * (bug 15101) Displaying only bots edits in Special:Recentchanges now works
106106 again
 107+* (bug 13770) Fixed incorrect detection of PHP's DOM module
107108
108109 === API changes in 1.14 ===
109110

Follow-up revisions

RevisionCommit summaryAuthorDate
r39159Backport r39158: fix for bug 13770: incorrect detection of DOM moduletstarling17:33, 11 August 2008
r40419Fix for bug 13770, second attempt. Tested with a conflicting install of both ...tstarling06:19, 4 September 2008
r40422Fix for bug 13770 (backport of r40419)tstarling07:10, 4 September 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r34283* (bug 13770) Use Preprocessor_Hash by default to avoid missing DOM module er...brion00:01, 6 May 2008
r34284* (bug 13770) Use Preprocessor_Hash by default to avoid missing DOM module er...brion00:01, 6 May 2008

Status & tagging log