r40422 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40421‎ | r40422 | r40423 >
Date:07:10, 4 September 2008
Author:tstarling
Status:old
Tags:
Comment:
Fix for bug 13770 (backport of r40419)
Modified paths:
  • /branches/REL1_13/phase3/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: branches/REL1_13/phase3/includes/parser/Parser.php
@@ -133,6 +133,10 @@
134134 $this->mVarCache = array();
135135 if ( isset( $conf['preprocessorClass'] ) ) {
136136 $this->mPreprocessorClass = $conf['preprocessorClass'];
 137+ } elseif ( extension_loaded( 'domxml' ) ) {
 138+ // PECL extension that conflicts with the core DOM extension (bug 13770)
 139+ wfDebug( "Warning: you have the obsolete domxml extension for PHP. Please remove it!\n" );
 140+ $this->mPreprocessorClass = 'Preprocessor_Hash';
137141 } elseif ( extension_loaded( 'dom' ) ) {
138142 $this->mPreprocessorClass = 'Preprocessor_DOM';
139143 } else {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r34283* (bug 13770) Use Preprocessor_Hash by default to avoid missing DOM module er...brion00:01, 6 May 2008
r34284* (bug 13770) Use Preprocessor_Hash by default to avoid missing DOM module er...brion00:01, 6 May 2008
r39158Fixed incorrect detection of PHP's DOM module (bug 13770)tstarling17:24, 11 August 2008
r39159Backport r39158: fix for bug 13770: incorrect detection of DOM moduletstarling17:33, 11 August 2008
r40419Fix for bug 13770, second attempt. Tested with a conflicting install of both ...tstarling06:19, 4 September 2008