r40414 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40413‎ | r40414 | r40415 >
Date:03:13, 4 September 2008
Author:brion
Status:old
Tags:
Comment:
* (bug 2889) MediaWiki:Print.css applies to the printable version

MediaWiki:Handheld.css and MediaWiki:Print.css now available (handheld only if $wgHandheldStyle is configured).
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -566,6 +566,7 @@
567567 // If we use the site's dynamic CSS, throw that in, too
568568 // Per-site custom styles
569569 if( $wgUseSiteCss ) {
 570+ global $wgHandheldStyle;
570571 $query = wfArrayToCGI( array(
571572 'usemsgcache' => 'yes',
572573 'ctype' => 'text/css',
@@ -573,6 +574,10 @@
574575 ) + $siteargs );
575576 # Site settings must override extension css! (bug 15025)
576577 $out->addStyle( self::makeNSUrl( 'Common.css', $query, NS_MEDIAWIKI) );
 578+ $out->addStyle( self::makeNSUrl( 'Print.css', $query, NS_MEDIAWIKI), "print" );
 579+ if( $wgHandheldStyle ) {
 580+ $out->addStyle( self::makeNSUrl( 'Handheld.css', $query, NS_MEDIAWIKI), "handheld" );
 581+ }
577582 $out->addStyle( self::makeNSUrl( $this->getSkinName() . '.css', $query, NS_MEDIAWIKI ) );
578583 }
579584
Index: trunk/phase3/RELEASE-NOTES
@@ -112,6 +112,7 @@
113113 displaying an external image inline.
114114 * (bugs 15405, 15436) Sort more currency types correctly in sortable tables
115115 * (bug 15422) Sort more different types of numbers in sortable tables
 116+* (bug 2889) MediaWiki:Print.css applies to the printable version
116117
117118 === Bug fixes in 1.14 ===
118119

Follow-up revisions

RevisionCommit summaryAuthorDate
r40605Per r40414: Add new CSS files to message files.raymond11:09, 8 September 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r36308(bug 2889) MediaWiki:Print.css now applies to the printable versiondemon20:30, 15 June 2008
r36474Revert r36308 "(bug 2889) MediaWiki:Print.css now applies to the printable ve...brion18:18, 19 June 2008