r36474 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36473‎ | r36474 | r36475 >
Date:18:18, 19 June 2008
Author:brion
Status:old
Tags:
Comment:
Revert r36308 "(bug 2889) MediaWiki:Print.css now applies to the printable version"
Doesn't actually work -- it applies it to 'printable=yes' print simulation, but not to actual printable stylesheet.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinTemplate.php
@@ -962,8 +962,7 @@
963963 function setupUserCss() {
964964 wfProfileIn( __METHOD__ );
965965
966 - global $wgRequest, $wgAllowUserCss, $wgUseSiteCss,
967 - $wgContLang, $wgSquidMaxage, $wgStylePath, $wgUser, $wgOut;
 966+ global $wgRequest, $wgAllowUserCss, $wgUseSiteCss, $wgContLang, $wgSquidMaxage, $wgStylePath, $wgUser;
968967
969968 $sitecss = '';
970969 $usercss = '';
@@ -1006,7 +1005,6 @@
10071006 $sitecss .= '@import "' . self::makeNSUrl( 'Common.css', $query, NS_MEDIAWIKI) . '";' . "\n";
10081007 $sitecss .= '@import "' . self::makeNSUrl( ucfirst( $this->skinname ) . '.css', $query, NS_MEDIAWIKI ) . '";' . "\n";
10091008 $sitecss .= '@import "' . self::makeUrl( '-', "action=raw&gen=css$siteargs$skinquery" ) . '";' . "\n";
1010 - if( $wgOut->isPrintable()) $sitecss .= '@import "' . self::makeNSUrl( 'Print.css', $query, NS_MEDIAWIKI) . '";' . "\n";
10111009 }
10121010
10131011 # If we use any dynamic CSS, make a little CDATA block out of it.
Index: trunk/phase3/includes/Skin.php
@@ -416,7 +416,7 @@
417417
418418 # get the user/site-specific stylesheet, SkinTemplate loads via RawPage.php (settings are cached that way)
419419 function getUserStylesheet() {
420 - global $wgStylePath, $wgRequest, $wgContLang, $wgSquidMaxage, $wgStyleVersion, $wgOut;
 420+ global $wgStylePath, $wgRequest, $wgContLang, $wgSquidMaxage, $wgStyleVersion;
421421 $sheet = $this->getStylesheet();
422422 $s = "@import \"$wgStylePath/common/shared.css?$wgStyleVersion\";\n";
423423 $s .= "@import \"$wgStylePath/common/oldshared.css?$wgStyleVersion\";\n";
@@ -428,7 +428,6 @@
429429 '@import "' . self::makeNSUrl( ucfirst( $this->getSkinName() . '.css' ), $query, NS_MEDIAWIKI ) . "\";\n";
430430
431431 $s .= $this->doGetUserStyles();
432 - if($wgOut->isPrintable()) $s .= '@import "' . self::makeNSUrl( 'Print.css', $query, NS_MEDIAWIKI ) . "\";\n";
433432 return $s."\n";
434433 }
435434
@@ -529,7 +528,7 @@
530529 }
531530 return $s;
532531 }
533 -
 532+
534533 function getBodyOptions() {
535534 global $wgUser, $wgTitle, $wgOut, $wgRequest, $wgContLang;
536535
Index: trunk/phase3/RELEASE-NOTES
@@ -157,7 +157,6 @@
158158 external links.
159159 * (bug 14132) Allow user to disable bot edits from being output to UDP.
160160 * (bug 14328) jsMsg() within Wikibits now accepts a DOM object, not just a string
161 -* (bug 2889) MediaWiki:Print.css applies to the printable version
162161 * (bug 14558) New system message (emailuserfooter) is now added to the footer of
163162 e-mails sent with Special:Emailuser
164163 * Add support for Hijri (Islamic) calendar

Follow-up revisions

RevisionCommit summaryAuthorDate
r40414* (bug 2889) MediaWiki:Print.css applies to the printable version...brion03:13, 4 September 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r36308(bug 2889) MediaWiki:Print.css now applies to the printable versiondemon20:30, 15 June 2008

Status & tagging log