r40415 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40414‎ | r40415 | r40416 >
Date:03:22, 4 September 2008
Author:tstarling
Status:old
Tags:
Comment:
Documentation
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -2271,13 +2271,13 @@
22722272 }
22732273
22742274 /**
2275 - * Set the fragment for this title
2276 - * This is kind of bad, since except for this rarely-used function, Title objects
2277 - * are immutable. The reason this is here is because it's better than setting the
2278 - * members directly, which is what Linker::formatComment was doing previously.
 2275+ * Set the fragment for this title. Removes the first character from the
 2276+ * specified fragment before setting, so it assumes you're passing it with
 2277+ * an initial "#".
22792278 *
 2279+ * @deprecated Use Title::makeTitle() with fragment parameter.
 2280+ *
22802281 * @param $fragment \type{\string} text
2281 - * @todo clarify whether access is supposed to be public (was marked as "kind of public")
22822282 */
22832283 public function setFragment( $fragment ) {
22842284 $this->mFragment = str_replace( '_', ' ', substr( $fragment, 1 ) );