r38214 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38213‎ | r38214 | r38215 >
Date:03:23, 30 July 2008
Author:demon
Status:old
Tags:
Comment:
(bug 14977) Installations on servers using IPv6 addresses for $wgServer were largely unusable because $wgServer didn't wrap the IP in brackets
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
@@ -69,6 +69,12 @@
7070 $wgServerName = 'localhost';
7171 }
7272
 73+# Before we put http:// and other things onto it, need to
 74+# wrap IPv6 in []. Bug 14977.
 75+if ( IP::isIPv6( $wgServerName ) ) {
 76+ $wgServerName = '[' . $wgServerName . ']';
 77+}
 78+
7379 # check if server use https:
7480 $wgProto = (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on') ? 'https' : 'http';
7581
Index: trunk/phase3/RELEASE-NOTES
@@ -43,6 +43,8 @@
4444 * (bug 14954) Fix regression in Modern and Simple skins
4545 * Recursion loop check added to Categoryfinder class
4646 * Fixed few performance troubles of large job queue processing
 47+* (bug 14977) Installations on servers using IPv6 addresses for $wgServer
 48+ were largely unusable because $wgServer didn't wrap the IP in brackets.
4749
4850 === API changes in 1.14 ===
4951

Follow-up revisions

RevisionCommit summaryAuthorDate
r38251Revert r38214 (IPv6 check for $wgServerName) -- failing to load IP class in s...brion20:14, 30 July 2008
r90105* (bug 28798) Set $wgServer in the default LocalSettings.php...tstarling07:35, 15 June 2011
r90194Fixes for r90105, r90193:...tstarling05:52, 16 June 2011

Status & tagging log