r38215 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38214‎ | r38215 | r38216 >
Date:04:13, 30 July 2008
Author:demon
Status:old
Tags:
Comment:
The documented setting on MW.org (and in DefaultSettings) is $wgSearchForwardUrl, so tweaked Special:Search to use the newer (and better) titled setting. Should make it actually work as advertised now.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialSearch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialSearch.php
@@ -139,9 +139,9 @@
140140
141141 global $wgDisableTextSearch;
142142 if ( $wgDisableTextSearch ) {
143 - global $wgForwardSearchUrl;
144 - if( $wgForwardSearchUrl ) {
145 - $url = str_replace( '$1', urlencode( $term ), $wgForwardSearchUrl );
 143+ global $wgSearchForwardUrl;
 144+ if( $wgSearchForwardUrl ) {
 145+ $url = str_replace( '$1', urlencode( $term ), $wgSearchForwardUrl );
146146 $wgOut->redirect( $url );
147147 return;
148148 }
Index: trunk/phase3/RELEASE-NOTES
@@ -23,6 +23,8 @@
2424 * $wgExemptFromUserRobotsControl is an array of namespaces to be exempt from
2525 the effect of the new __INDEX__/__NOINDEX__ magic words. (Default: null, ex-
2626 empt all content namespaces.)
 27+* $wgForwardSearchUrl has been removed entirely. Documented setting since 1.4
 28+ has been $wgSearchForwardUrl.
2729
2830 === New features in 1.14 ===
2931

Follow-up revisions

RevisionCommit summaryAuthorDate
r38216Backport fix from r38215 to branch.demon04:15, 30 July 2008

Status & tagging log